Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: runtime/vm/stub_code_ia32.cc

Issue 2912863006: Inline instance object hash code into object header on 64 bit. (Closed)
Patch Set: Add assembler tests and other feedback from Ryan Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1059 matching lines...) Expand 10 before | Expand all | Expand 10 after
1070 } else { 1070 } else {
1071 __ j(ABOVE_EQUAL, &slow_case); 1071 __ j(ABOVE_EQUAL, &slow_case);
1072 } 1072 }
1073 __ movl(Address(EDI, Heap::TopOffset(space)), EBX); 1073 __ movl(Address(EDI, Heap::TopOffset(space)), EBX);
1074 NOT_IN_PRODUCT(__ UpdateAllocationStats(cls.id(), ECX, space)); 1074 NOT_IN_PRODUCT(__ UpdateAllocationStats(cls.id(), ECX, space));
1075 1075
1076 // EAX: new object start (untagged). 1076 // EAX: new object start (untagged).
1077 // EBX: next object start. 1077 // EBX: next object start.
1078 // EDX: new object type arguments (if is_cls_parameterized). 1078 // EDX: new object type arguments (if is_cls_parameterized).
1079 // Set the tags. 1079 // Set the tags.
1080 uword tags = 0; 1080 uint32_t tags = 0;
1081 tags = RawObject::SizeTag::update(instance_size, tags); 1081 tags = RawObject::SizeTag::update(instance_size, tags);
1082 ASSERT(cls.id() != kIllegalCid); 1082 ASSERT(cls.id() != kIllegalCid);
1083 tags = RawObject::ClassIdTag::update(cls.id(), tags); 1083 tags = RawObject::ClassIdTag::update(cls.id(), tags);
1084 __ movl(Address(EAX, Instance::tags_offset()), Immediate(tags)); 1084 __ movl(Address(EAX, Instance::tags_offset()), Immediate(tags));
1085 __ addl(EAX, Immediate(kHeapObjectTag)); 1085 __ addl(EAX, Immediate(kHeapObjectTag));
1086 1086
1087 // Initialize the remaining words of the object. 1087 // Initialize the remaining words of the object.
1088 1088
1089 // EAX: new object (tagged). 1089 // EAX: new object (tagged).
1090 // EBX: next object start. 1090 // EBX: next object start.
(...skipping 1044 matching lines...) Expand 10 before | Expand all | Expand 10 after
2135 } 2135 }
2136 2136
2137 2137
2138 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) { 2138 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) {
2139 __ int3(); 2139 __ int3();
2140 } 2140 }
2141 2141
2142 } // namespace dart 2142 } // namespace dart
2143 2143
2144 #endif // defined TARGET_ARCH_IA32 2144 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698