ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm - Issue 2912863005: Use MDCTypography instead of MDFRobotoFontLoader directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm

Issue 2912863005: Use MDCTypography instead of MDFRobotoFontLoader directly. (Closed)

Patch Set: Update target value in unit test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.mm ('k') | ios/chrome/browser/ui/collection_view/cells/collection_view_account_item.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm

diff --git a/ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm b/ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm

index 6338e7327af21b9aaa07748ab63bbd6d4b7a58f0..471e6f7ad88a89d260d1c5af1c71602128dbc5df 100644

--- a/ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm

+++ b/ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm

@@ -52,7 +52,7 @@ TEST(MDCCollectionViewCellChrome, PreferredHeight) {

forItem:footerItem];

};

EXPECT_NEAR(heightForWidth(300), 50, 5);

- EXPECT_NEAR(heightForWidth(100), 110, 5);

+ EXPECT_NEAR(heightForWidth(100), 115, 5);

lpromero 2017/05/31 15:14:48 With Roboto, heightForWidth(100) returns 114.5. Wi

}

} // namespace