Fix an exception caused by incomplete input (issue 29687)

Fix an exception caused by incomplete input (issue 29687)

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/852edf38d9f77dbea13d990f333e8b85b003b755

[Brian Wilkerson, 2017-05-30 16:39:48]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-05-30 16:39:48]

I'm not sure where / how to write a test for this, but did verify by hand.

[Brian Wilkerson, 2017-05-30 17:22:20]

Thanks! I added a test, and fixed a bug in checked mode. PTAL.

[scheglov, 2017-05-30 17:25:18]

LGTM

https://codereview.chromium.org/2912843004/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/summarize_const_expr.dart (right):

https://codereview.chromium.org/2912843004/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/summarize_const_expr.dart:290: value = 0;
This could be also.

value ??= 0;

https://codereview.chromium.org/2912843004/diff/20001/pkg/analyzer/test/src/s...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2912843004/diff/20001/pkg/analyzer/test/src/s...
pkg/analyzer/test/src/summary/resynthesize_common.dart:3312: const int x = 0;
I don't think we do this for all the tests, but in this case strong mode and
spec mode expectations are the same, so we could remove "if" and just do the
same check.

[Brian Wilkerson, 2017-05-30 17:38:45]

https://codereview.chromium.org/2912843004/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/summarize_const_expr.dart (right):

https://codereview.chromium.org/2912843004/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/summarize_const_expr.dart:290: value = 0;
Done

https://codereview.chromium.org/2912843004/diff/20001/pkg/analyzer/test/src/s...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2912843004/diff/20001/pkg/analyzer/test/src/s...
pkg/analyzer/test/src/summary/resynthesize_common.dart:3312: const int x = 0;
Done

[Brian Wilkerson, 2017-05-30 17:39:03]

Description was changed from

==========
Fix an exception caused by incomplete input (issue 29687)
==========

to

==========
Fix an exception caused by incomplete input (issue 29687)

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/852edf38d9f77dbea13d990f333e8b85b003b755
==========

[Brian Wilkerson, 2017-05-30 17:39:06]

Committed patchset #2 (id:20001) manually as
852edf38d9f77dbea13d990f333e8b85b003b755 (presubmit successful).