Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: components/translate/core/common/BUILD.gn

Issue 2912843003: Refactoring ConstructLanguageDetectionEvent. (Closed)
Patch Set: updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/DEPS ('k') | components/translate/core/common/language_detection_logging_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/common/BUILD.gn
diff --git a/components/translate/core/common/BUILD.gn b/components/translate/core/common/BUILD.gn
index f8038c92d811a49a87829c19decbd7f7716bfd9b..5aca8ab319ce688be5d14e1948aee0c52921a171 100644
--- a/components/translate/core/common/BUILD.gn
+++ b/components/translate/core/common/BUILD.gn
@@ -6,6 +6,8 @@ static_library("common") {
sources = [
"language_detection_details.cc",
"language_detection_details.h",
+ "language_detection_logging_helper.cc",
+ "language_detection_logging_helper.h",
"translate_constants.cc",
"translate_constants.h",
"translate_errors.h",
@@ -19,6 +21,7 @@ static_library("common") {
deps = [
"//base",
+ "//components/sync/protocol",
"//url",
]
}
@@ -26,12 +29,14 @@ static_library("common") {
source_set("unit_tests") {
testonly = true
sources = [
+ "language_detection_logging_helper_unittest.cc",
"translate_metrics_unittest.cc",
"translate_util_unittest.cc",
]
deps = [
":common",
"//base",
+ "//components/sync/protocol",
"//testing/gtest",
"//url",
]
« no previous file with comments | « components/translate/DEPS ('k') | components/translate/core/common/language_detection_logging_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698