Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 291283002: Fix loadtimedata error message on non-Chrome OS (Closed)

Created:
6 years, 7 months ago by michaelpg
Modified:
6 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nona+watch_chromium.org, yukishiino+watch_chromium.org, arv+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Fix loadtimedata error message on non-Chrome OS BUG=none TEST=no warnings output in existing tests R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272012

Patch Set 1 #

Total comments: 2

Patch Set 2 : check valueExists instead of isChromeOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/options/language_options.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
michaelpg
6 years, 7 months ago (2014-05-20 22:54:24 UTC) #1
Dan Beam
https://codereview.chromium.org/291283002/diff/1/chrome/browser/resources/options/language_options.js File chrome/browser/resources/options/language_options.js (right): https://codereview.chromium.org/291283002/diff/1/chrome/browser/resources/options/language_options.js#newcode572 chrome/browser/resources/options/language_options.js:572: if (cr.isChromeOS && loadTimeData.getBoolean('secondaryUser')) { why not loadTimeData.valueExists('secondaryUser')?
6 years, 7 months ago (2014-05-20 23:34:09 UTC) #2
michaelpg
https://codereview.chromium.org/291283002/diff/1/chrome/browser/resources/options/language_options.js File chrome/browser/resources/options/language_options.js (right): https://codereview.chromium.org/291283002/diff/1/chrome/browser/resources/options/language_options.js#newcode572 chrome/browser/resources/options/language_options.js:572: if (cr.isChromeOS && loadTimeData.getBoolean('secondaryUser')) { On 2014/05/20 23:34:09, Dan ...
6 years, 7 months ago (2014-05-20 23:39:53 UTC) #3
Dan Beam
tilgtm'd
6 years, 7 months ago (2014-05-21 00:09:31 UTC) #4
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 7 months ago (2014-05-21 03:27:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/291283002/20001
6 years, 7 months ago (2014-05-21 03:28:40 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 23:29:24 UTC) #7
Message was sent while issue was closed. 
Change committed as 272012

Powered by Google App Engine
This is Rietveld 408576698