Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: components/password_manager/core/browser/form_fetcher.h

Issue 2912783002: Measure how often PSL and same-organization name credentials are suppressed. (Closed)
Patch Set: Addressed comments from kolos@. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/form_fetcher.h
diff --git a/components/password_manager/core/browser/form_fetcher.h b/components/password_manager/core/browser/form_fetcher.h
index 05400dc8b1cd3df8d51be7fa722224fd0767138b..22bcd52aa554ec105fb0a930bf79712d11d89c91 100644
--- a/components/password_manager/core/browser/form_fetcher.h
+++ b/components/password_manager/core/browser/form_fetcher.h
@@ -71,22 +71,41 @@ class FormFetcher {
virtual const std::vector<const autofill::PasswordForm*>&
GetFederatedMatches() const = 0;
- // When this instance fetches forms for an HTTP origin: Returns credentials,
- // if any, found for the HTTPS version of that origin. These results are
- // queried on a best-effort basis, might be somewhat stale, and are normally
- // available shortly after the first Consumer::ProcessMatches callback.
+ // The following accessors return various kinds of `suppressed` credentials.
+ // These are stored credentials that are not (auto-)filled, because they are
+ // for an origin that is similar to, but not exactly matching the origin that
+ // this FormFetcher was created for. They are used for recording metrics on
+ // how often such -- potentially, but not necessarily related -- credentials
+ // are not offered to the user, unduly increasing log-in friction.
//
- // When there exists no precisely matching HTTP credentials for an origin, but
- // there are suppressed HTTPS credentials, that could indicate a premature
- // `move-to-HTTPS` migration, or simply that the site serves its sign-up or
- // some of its sign-in forms over HTTPS, while others still over HTTP.
+ // There are currently three kinds of suppressed credentials:
+ // 1.) HTTPS credentials not filled on the HTTP version of the origin.
+ // 2.) PSL-matches that are not auto-filled (but filled on account select).
+ // 3.) Same-organization name credentials, not filled.
+ //
+ // Results below are queried on a best-effort basis, might be somewhat stale,
+ // and are available shortly after the Consumer::ProcessMatches callback.
+
+ // When this instance fetches forms for an HTTP origin: Returns saved
+ // credentials, if any, found for the HTTPS version of that origin. Empty
+ // otherwise.
virtual const std::vector<const autofill::PasswordForm*>&
GetSuppressedHTTPSForms() const = 0;
- // Whether querying the results for GetSuppressedHTTPSForms was attempted and
- // did complete at least once during the lifetime of this instance, regardless
- // of whether there have been any suppressed HTTPS forms.
- virtual bool DidCompleteQueryingSuppressedHTTPSForms() const = 0;
+ // Returns saved credentials, if any, for PSL-matching origins. Autofilling
+ // these is suppressed, however, they *can be* filled on account select.
+ virtual const std::vector<const autofill::PasswordForm*>&
+ GetSuppressedPSLMatchingForms() const = 0;
+
+ // Returns saved credentials, if any, found for HTTP/HTTPS origins with the
+ // same organization name as the origin this FormFetcher was created for.
+ virtual const std::vector<const autofill::PasswordForm*>&
+ GetSuppressedSameOrganizationNameForms() const = 0;
+
+ // Whether querying suppressed forms (of all flavors) was attempted and did
+ // complete at least once during the lifetime of this instance, regardless of
+ // whether there have been any results.
+ virtual bool DidCompleteQueryingSuppressedForms() const = 0;
// Fetches stored matching logins. In addition the statistics is fetched on
// platforms with the password bubble. This is called automatically during

Powered by Google App Engine
This is Rietveld 408576698