Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: components/password_manager/core/browser/suppressed_https_form_fetcher.h

Issue 2912783002: Measure how often PSL and same-organization name credentials are suppressed. (Closed)
Patch Set: Addressed comments from kolos@. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/suppressed_https_form_fetcher.h
diff --git a/components/password_manager/core/browser/suppressed_https_form_fetcher.h b/components/password_manager/core/browser/suppressed_https_form_fetcher.h
deleted file mode 100644
index b8123689f408f2729b37ff52ba3bb5a4a832a5d3..0000000000000000000000000000000000000000
--- a/components/password_manager/core/browser/suppressed_https_form_fetcher.h
+++ /dev/null
@@ -1,63 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SUPPRESSED_HTTPS_FORM_FETCHER_H_
-#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SUPPRESSED_HTTPS_FORM_FETCHER_H_
-
-#include <memory>
-#include <vector>
-
-#include "base/gtest_prod_util.h"
-#include "base/macros.h"
-#include "components/autofill/core/common/password_form.h"
-#include "components/password_manager/core/browser/password_store_consumer.h"
-#include "url/gurl.h"
-
-namespace password_manager {
-
-class PasswordManagerClient;
-
-// Fetches credentials saved for the HTTPS counterpart of the given HTTP realm.
-//
-// Filling these HTTPS credentials into forms served over HTTP is obviously
-// suppressed, the purpose of doing such a query is to collect metrics on how
-// often this happens and inconveniences the user.
-//
-// This logic is implemented by this class, a separate PasswordStore consumer,
-// to make it very sure that these credentials will not get mistakenly filled.
-class SuppressedHTTPSFormFetcher : public PasswordStoreConsumer {
- public:
- // Interface to be implemented by the consumer of this class.
- class Consumer {
- public:
- virtual void ProcessSuppressedHTTPSForms(
- std::vector<std::unique_ptr<autofill::PasswordForm>> forms) = 0;
- };
-
- SuppressedHTTPSFormFetcher(const std::string& observed_signon_realm,
- const PasswordManagerClient* client,
- Consumer* consumer);
- ~SuppressedHTTPSFormFetcher() override;
-
- protected:
- // PasswordStoreConsumer:
- void OnGetPasswordStoreResults(
- std::vector<std::unique_ptr<autofill::PasswordForm>> results) override;
-
- private:
- FRIEND_TEST_ALL_PREFIXES(SuppressedHTTPSFormFetcherTest, EmptyStore);
- FRIEND_TEST_ALL_PREFIXES(SuppressedHTTPSFormFetcherTest, FullStore);
-
- // The client and the consumer should outlive |this|.
- const PasswordManagerClient* client_;
- Consumer* consumer_;
-
- const GURL observed_signon_realm_as_url_;
-
- DISALLOW_COPY_AND_ASSIGN(SuppressedHTTPSFormFetcher);
-};
-
-} // namespace password_manager
-
-#endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SUPPRESSED_HTTPS_FORM_FETCHER_H_

Powered by Google App Engine
This is Rietveld 408576698