Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: src/objects-inl.h

Issue 2912773002: Rename "NoBarrier" memory operations to "Relaxed". (Closed)
Patch Set: comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects/object-macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 221ed4c2cccaa4700df8908742c6aab2bc9205b6..ce079481e818944fd3128ae6ff6862f5f595d203 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1331,13 +1331,13 @@ HeapObject** HeapObject::map_slot() {
MapWord HeapObject::map_word() const {
return MapWord(
- reinterpret_cast<uintptr_t>(NOBARRIER_READ_FIELD(this, kMapOffset)));
+ reinterpret_cast<uintptr_t>(RELAXED_READ_FIELD(this, kMapOffset)));
}
void HeapObject::set_map_word(MapWord map_word) {
- NOBARRIER_WRITE_FIELD(
- this, kMapOffset, reinterpret_cast<Object*>(map_word.value_));
+ RELAXED_WRITE_FIELD(this, kMapOffset,
+ reinterpret_cast<Object*>(map_word.value_));
}
@@ -2187,7 +2187,7 @@ void Object::VerifyApiCallResultType() {
Object* FixedArray::get(int index) const {
SLOW_DCHECK(index >= 0 && index < this->length());
- return NOBARRIER_READ_FIELD(this, kHeaderSize + index * kPointerSize);
+ return RELAXED_READ_FIELD(this, kHeaderSize + index * kPointerSize);
}
Handle<Object> FixedArray::get(FixedArray* array, int index, Isolate* isolate) {
@@ -2216,7 +2216,7 @@ void FixedArray::set(int index, Smi* value) {
DCHECK(index >= 0 && index < this->length());
DCHECK(reinterpret_cast<Object*>(value)->IsSmi());
int offset = kHeaderSize + index * kPointerSize;
- NOBARRIER_WRITE_FIELD(this, offset, value);
+ RELAXED_WRITE_FIELD(this, offset, value);
}
@@ -2226,7 +2226,7 @@ void FixedArray::set(int index, Object* value) {
DCHECK_GE(index, 0);
DCHECK_LT(index, this->length());
int offset = kHeaderSize + index * kPointerSize;
- NOBARRIER_WRITE_FIELD(this, offset, value);
+ RELAXED_WRITE_FIELD(this, offset, value);
WRITE_BARRIER(GetHeap(), this, offset, value);
}
@@ -2451,7 +2451,7 @@ void FixedArray::set(int index,
DCHECK_GE(index, 0);
DCHECK_LT(index, this->length());
int offset = kHeaderSize + index * kPointerSize;
- NOBARRIER_WRITE_FIELD(this, offset, value);
+ RELAXED_WRITE_FIELD(this, offset, value);
CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode);
}
@@ -2463,7 +2463,7 @@ void FixedArray::NoWriteBarrierSet(FixedArray* array,
DCHECK_GE(index, 0);
DCHECK_LT(index, array->length());
DCHECK(!array->GetHeap()->InNewSpace(value));
- NOBARRIER_WRITE_FIELD(array, kHeaderSize + index * kPointerSize, value);
+ RELAXED_WRITE_FIELD(array, kHeaderSize + index * kPointerSize, value);
}
void FixedArray::set_undefined(int index) {
@@ -3210,7 +3210,7 @@ SMI_ACCESSORS(FixedArrayBase, length, kLengthOffset)
SYNCHRONIZED_SMI_ACCESSORS(FixedArrayBase, length, kLengthOffset)
SMI_ACCESSORS(FreeSpace, size, kSizeOffset)
-NOBARRIER_SMI_ACCESSORS(FreeSpace, size, kSizeOffset)
+RELAXED_SMI_ACCESSORS(FreeSpace, size, kSizeOffset)
SMI_ACCESSORS(String, length, kLengthOffset)
SYNCHRONIZED_SMI_ACCESSORS(String, length, kLengthOffset)
@@ -3222,7 +3222,7 @@ int FreeSpace::Size() { return size(); }
FreeSpace* FreeSpace::next() {
DCHECK(map() == GetHeap()->root(Heap::kFreeSpaceMapRootIndex) ||
(!GetHeap()->deserialization_complete() && map() == NULL));
- DCHECK_LE(kNextOffset + kPointerSize, nobarrier_size());
+ DCHECK_LE(kNextOffset + kPointerSize, relaxed_read_size());
return reinterpret_cast<FreeSpace*>(
Memory::Address_at(address() + kNextOffset));
}
@@ -3231,8 +3231,8 @@ FreeSpace* FreeSpace::next() {
void FreeSpace::set_next(FreeSpace* next) {
DCHECK(map() == GetHeap()->root(Heap::kFreeSpaceMapRootIndex) ||
(!GetHeap()->deserialization_complete() && map() == NULL));
- DCHECK_LE(kNextOffset + kPointerSize, nobarrier_size());
- base::NoBarrier_Store(
+ DCHECK_LE(kNextOffset + kPointerSize, relaxed_read_size());
+ base::Relaxed_Store(
reinterpret_cast<base::AtomicWord*>(address() + kNextOffset),
reinterpret_cast<base::AtomicWord>(next));
}
@@ -4113,8 +4113,7 @@ void Map::set_visitor_id(int id) {
int Map::instance_size() {
- return NOBARRIER_READ_BYTE_FIELD(
- this, kInstanceSizeOffset) << kPointerSizeLog2;
+ return RELAXED_READ_BYTE_FIELD(this, kInstanceSizeOffset) << kPointerSizeLog2;
}
@@ -4194,7 +4193,7 @@ int HeapObject::SizeFromMap(Map* map) {
return reinterpret_cast<BytecodeArray*>(this)->BytecodeArraySize();
}
if (instance_type == FREE_SPACE_TYPE) {
- return reinterpret_cast<FreeSpace*>(this)->nobarrier_size();
+ return reinterpret_cast<FreeSpace*>(this)->relaxed_read_size();
}
if (instance_type == STRING_TYPE ||
instance_type == INTERNALIZED_STRING_TYPE) {
@@ -4224,8 +4223,7 @@ void Map::set_instance_size(int value) {
DCHECK_EQ(0, value & (kPointerSize - 1));
value >>= kPointerSizeLog2;
DCHECK(0 <= value && value < 256);
- NOBARRIER_WRITE_BYTE_FIELD(
- this, kInstanceSizeOffset, static_cast<byte>(value));
+ RELAXED_WRITE_BYTE_FIELD(this, kInstanceSizeOffset, static_cast<byte>(value));
}
@@ -6426,7 +6424,7 @@ void Foreign::set_foreign_address(Address value) {
template <class Derived>
void SmallOrderedHashTable<Derived>::SetDataEntry(int entry, Object* value) {
int offset = GetDataEntryOffset(entry);
- NOBARRIER_WRITE_FIELD(this, offset, value);
+ RELAXED_WRITE_FIELD(this, offset, value);
WRITE_BARRIER(GetHeap(), this, offset, value);
}
« no previous file with comments | « src/objects.h ('k') | src/objects/object-macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698