Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: src/heap/marking.h

Issue 2912773002: Rename "NoBarrier" memory operations to "Relaxed". (Closed)
Patch Set: comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/objects-visiting.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/marking.h
diff --git a/src/heap/marking.h b/src/heap/marking.h
index d9514d181a77f4286a9da82c916ec6904c8c6b3e..dcf78aac1c5e16cc28c98a073fecb85203de57c7 100644
--- a/src/heap/marking.h
+++ b/src/heap/marking.h
@@ -71,7 +71,7 @@ inline bool MarkBit::Set<MarkBit::ATOMIC>() {
base::Atomic32 old_value;
base::Atomic32 new_value;
do {
- old_value = base::NoBarrier_Load(cell_);
+ old_value = base::Relaxed_Load(cell_);
if (old_value & mask_) return false;
new_value = old_value | mask_;
} while (base::Release_CompareAndSwap(cell_, old_value, new_value) !=
@@ -81,7 +81,7 @@ inline bool MarkBit::Set<MarkBit::ATOMIC>() {
template <>
inline bool MarkBit::Get<MarkBit::NON_ATOMIC>() {
- return (base::NoBarrier_Load(cell_) & mask_) != 0;
+ return (base::Relaxed_Load(cell_) & mask_) != 0;
}
template <>
@@ -101,7 +101,7 @@ inline bool MarkBit::Clear<MarkBit::ATOMIC>() {
base::Atomic32 old_value;
base::Atomic32 new_value;
do {
- old_value = base::NoBarrier_Load(cell_);
+ old_value = base::Relaxed_Load(cell_);
if (!(old_value & mask_)) return false;
new_value = old_value & ~mask_;
} while (base::Release_CompareAndSwap(cell_, old_value, new_value) !=
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/objects-visiting.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698