Hit breakpoints in single line closures.

Hit breakpoints in single line closures.

Before this change, breakpoints on lines like the following were not hit:

var singleLineClosure = (int a, int b) => return a + b;

The reason was that breakpoints were only resolved if their start token
was contained within a function. Since that is not true for closure vars
like in the above example, the breakpoints were never getting resolved.
This change avoids such a problem by resolving breakpoints if the token
range of the breakpoint overlaps the token range of a function.

Fixes #29736

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/ffeaa4a46d0e8ff6a99dfc443ada9b9abd1e51d8

[sivachandra, 2017-05-31 00:25:22]

sivachandra@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-05-31 19:20:55]

LGTM with one comment.

https://codereview.chromium.org/2912763005/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2912763005/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2728: if (IsImplicitFunction(function)) {
Should this also include other function types that do not have a source e.g:
kInvokeFieldDispatcher, kNoSuchMethodDispatcher, kMethodExtractor,
kIrregexpFunction

[sivachandra, 2017-05-31 20:16:47]

https://codereview.chromium.org/2912763005/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2912763005/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2728: if (IsImplicitFunction(function)) {
On 2017/05/31 19:20:54, siva wrote:
> Should this also include other function types that do not have a source e.g:
> kInvokeFieldDispatcher, kNoSuchMethodDispatcher, kMethodExtractor,
> kIrregexpFunction

Likewise, I think there are implicit constructors as well? AFAICT, there is no
kind for an implicit constructor. Do you think we should use a heuristic like
start_token_pos == end_token_pos to determine whether a function is an implicit
function? This will cover the implicit constructors as well.

[sivachandra, 2017-05-31 21:28:16]

As discussed offline, enhanced the check to filter out implicit functions.

[siva, 2017-05-31 21:51:43]

lgtm

[sivachandra, 2017-06-01 18:26:11]

Description was changed from

==========
Hit breakpoints in single line closures.

Before this change, breakpoints on lines like the following were not hit:

var singleLineClosure = (int a, int b) => return a + b;

The reason was that breakpoints were only resolved if their start token
was contained within a function. Since that is not true for closure vars
like in the above example, the breakpoints were never getting resolved.
This change avoids such a problem by resolving breakpoints if the token
range of the breakpoint overlaps the token range of a function.

Fixes #29736
==========

to

==========
Hit breakpoints in single line closures.

Before this change, breakpoints on lines like the following were not hit:

var singleLineClosure = (int a, int b) => return a + b;

The reason was that breakpoints were only resolved if their start token
was contained within a function. Since that is not true for closure vars
like in the above example, the breakpoints were never getting resolved.
This change avoids such a problem by resolving breakpoints if the token
range of the breakpoint overlaps the token range of a function.

Fixes #29736

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ffeaa4a46d0e8ff6a99dfc443ada9b9abd1e51d8
==========

[sivachandra, 2017-06-01 18:26:12]

Committed patchset #3 (id:40001) manually as
ffeaa4a46d0e8ff6a99dfc443ada9b9abd1e51d8 (presubmit successful).