Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp

Issue 2912663002: Clean up creation of "detached" SVG* data type objects (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp b/third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp
index 1d8de80cd059cb765a23a2a1912aafb37183f660..bc69419a0e7791c6c4d6b025070a7406d10dc301 100644
--- a/third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp
@@ -64,8 +64,12 @@ void SVGPointTearOff::setY(float f, ExceptionState& exception_state) {
SVGPointTearOff* SVGPointTearOff::matrixTransform(SVGMatrixTearOff* matrix) {
FloatPoint point = Target()->MatrixTransform(matrix->Value());
- return SVGPointTearOff::Create(SVGPoint::Create(point), 0,
- kPropertyIsNotAnimVal);
+ return CreateDetached(point);
+}
+
+SVGPointTearOff* SVGPointTearOff::CreateDetached(const FloatPoint& point) {
+ return Create(SVGPoint::Create(point), nullptr, kPropertyIsNotAnimVal,
+ QualifiedName::Null());
}
DEFINE_TRACE_WRAPPERS(SVGPointTearOff) {

Powered by Google App Engine
This is Rietveld 408576698