Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGRectTearOff.cpp

Issue 2912663002: Clean up creation of "detached" SVG* data type objects (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 void SVGRectTearOff::setHeight(float f, ExceptionState& exception_state) { 73 void SVGRectTearOff::setHeight(float f, ExceptionState& exception_state) {
74 if (IsImmutable()) { 74 if (IsImmutable()) {
75 ThrowReadOnly(exception_state); 75 ThrowReadOnly(exception_state);
76 return; 76 return;
77 } 77 }
78 Target()->SetHeight(f); 78 Target()->SetHeight(f);
79 CommitChange(); 79 CommitChange();
80 } 80 }
81 81
82 SVGRectTearOff* SVGRectTearOff::CreateDetached(const FloatRect& rect) {
83 return Create(SVGRect::Create(rect), nullptr, kPropertyIsNotAnimVal,
84 QualifiedName::Null());
85 }
86
82 DEFINE_TRACE_WRAPPERS(SVGRectTearOff) { 87 DEFINE_TRACE_WRAPPERS(SVGRectTearOff) {
83 visitor->TraceWrappers(contextElement()); 88 visitor->TraceWrappers(contextElement());
84 } 89 }
85 90
86 } // namespace blink 91 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGRectTearOff.h ('k') | third_party/WebKit/Source/core/svg/SVGSVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698