Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGNumberTearOff.cpp

Issue 2912663002: Clean up creation of "detached" SVG* data type objects (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 void SVGNumberTearOff::setValue(float f, ExceptionState& exception_state) { 46 void SVGNumberTearOff::setValue(float f, ExceptionState& exception_state) {
47 if (IsImmutable()) { 47 if (IsImmutable()) {
48 ThrowReadOnly(exception_state); 48 ThrowReadOnly(exception_state);
49 return; 49 return;
50 } 50 }
51 Target()->SetValue(f); 51 Target()->SetValue(f);
52 CommitChange(); 52 CommitChange();
53 } 53 }
54 54
55 SVGNumberTearOff* SVGNumberTearOff::CreateDetached() {
56 return Create(SVGNumber::Create(), nullptr, kPropertyIsNotAnimVal,
57 QualifiedName::Null());
58 }
59
55 DEFINE_TRACE_WRAPPERS(SVGNumberTearOff) { 60 DEFINE_TRACE_WRAPPERS(SVGNumberTearOff) {
56 visitor->TraceWrappers(contextElement()); 61 visitor->TraceWrappers(contextElement());
57 } 62 }
58 63
59 } // namespace blink 64 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGNumberTearOff.h ('k') | third_party/WebKit/Source/core/svg/SVGPathElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698