bluetooth: macOS: Adding histograms for NSError values

device/bluetooth/bluetooth_adapter_mac_metrics.h

Index: device/bluetooth/bluetooth_adapter_mac_metrics.h
diff --git a/device/bluetooth/bluetooth_adapter_mac_metrics.h b/device/bluetooth/bluetooth_adapter_mac_metrics.h
new file mode 100644
index 0000000000000000000000000000000000000000..e84f8e3dc08d38c5310ab5bc16721dceb592140f
--- /dev/null
+++ b/device/bluetooth/bluetooth_adapter_mac_metrics.h
@@ -0,0 +1,71 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_MAC_METRICS_H_
+#define DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_MAC_METRICS_H_
+
+@class NSError;
+
+enum class WebBluetoothMacOSAPIs : int {

[scheib, 2017/08/15 22:20:28]

I don't think this enum is used, and can be removed.

If it is used, it shouldn't have 'WebBluetooth' in the name, as this is
recording values common to all core bluetooth & device/bluetooh clients. 

[jlebel, 2017/08/15 23:05:49]

Done.

+  DID_FAIL_TO_CONNECT_TO_PERIPHERAL = 0,
+  DID_DISCONNECT_PERIPHERAL,
+  DID_DISCOVER_PRIMARY_SERVICES,
+  DID_DISCOVER_CHARACTERISTICS,
+  DID_UPDATE_VALUE,
+  DID_WRITE_VALUE,
+  DID_UPDATE_NOTIFICATION_STATE,
+  DID_DISCOVER_DESCRIPTORS,
+  DID_UPDATE_VALUE_FOR_DESCRIPTOR,
+  DID_WRITE_VALUE_FOR_DESCRIPTOR,
+};
+
+enum class MacOSBluetoothOperationsResult : int {
+  UNKNOWN_ERROR_DOMAIN = -2,
+  NO_ERROR = -1,
+  CBATT_ERROR_SUCCESS = 0,
+  CBATT_ERROR_INVALID_HANDLE = 1,
+  CBATT_ERROR_READ_NOT_PERMITTED = 2,
+  CBATT_ERROR_WRITE_NOT_PERMITTED = 3,
+  CBATT_ERROR_INVALID_PDU = 4,
+  CBATT_ERROR_INSUFFICIENT_AUTHENTICATION = 5,
+  CBATT_ERROR_REQUEST_NOT_SUPPORTED = 6,
+  CBATT_ERROR_INVALID_OFFSET = 7,
+  CBATT_ERROR_INSUFFICIENT_AUTHORIZATION = 8,
+  CBATT_ERROR_PREPARE_QUEUE_FULL = 9,
+  CBATT_ERROR_ATTRIBUTE_NOT_FOUND = 10,
+  CBATT_ERROR_ATTRIBUTE_NOT_LONG = 11,
+  CBATT_ERROR_INSUFFICIENT_ENCRYPTION_KEY_SIZE = 12,
+  CBATT_ERROR_INVALID_ATTRIBUTE_VALUE_LENGTH = 13,
+  CBATT_ERROR_UNLIKELY_ERROR = 14,
+  CBATT_ERROR_INSUFFICIENT_ENCRYPTION = 15,
+  CBATT_ERROR_UNSUPPORTED_GROUP_TYPE = 16,
+  CBATT_ERROR_INSUFFICIENT_RESOURCES = 17,
+  CBATT_ERROR_MAX = 999,
+  CBERROR_UNKNOWN = 1000,
+  CBERROR_INVALID_PARAMETERS = 1001,
+  CBERROR_INVALID_HANDLE = 1002,
+  CBERROR_NOT_CONNECTED = 1003,
+  CBERROR_OUT_OF_SPACE = 1004,
+  CBERROR_OPERATION_CANCELLED = 1005,
+  CBERROR_CONNECTION_TIMEOUT = 1005,
+  CBERROR_PERIPHERAL_DISCONNECTED = 1007,
+  CBERROR_UUID_NOT_ALLOWED = 1008,
+  CBERROR_ALREADY_ADVERTISING = 1010,
+  CBERROR_MAX_CONNECTION = 1011,
+  CBERROR_MAX = 1999,
+  MAX,
+};
+
+void RecordDidFailToConnectPeripheralResult(NSError* error);
+void RecordDidDisconnectPeripheralResult(NSError* error);
+void RecordDidDiscoverPrimaryServicesResult(NSError* error);
+void RecordDidDiscoverCharacteristicsResult(NSError* error);
+void RecordDidUpdateValueResult(NSError* error);
+void RecordDidWriteValueResult(NSError* error);
+void RecordDidUpdateNotificationStateResult(NSError* error);
+void RecordDidDiscoverDescriptorsResult(NSError* error);
+void RecordDidUpdateValueForDescriptorResult(NSError* error);
+void RecordDidWriteValueForDescriptorResult(NSError* error);
+
+#endif  // DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_MAC_METRICS_H_