tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 5fdc25829c7c6402f41f31911c38061a5b1d2951..cd7b9001ff108ee981d7556e54594f26ef8e387b 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -6051,6 +6051,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Bluetooth.Web.MacOS.Errors" enum="WebBluetoothMacOSErrors" base="true">

[ortuno, 2017/05/31 06:59:52]

If we use ATT_ERROR_SUCCESS for error == nil then we can name this just
Bluetooth.Web.MacOS to match android.

[jlebel, 2017/06/13 22:31:38]

Well, we should not receive ATT_ERROR_SUCCESS. But if we do, we definitely get
error != nil.
I think the suffix is fine. But I can remove it if you prefer.

[ortuno, 2017/06/14 03:46:29]

What bothers me is having to maintain two huge lists of enums. If we can use the
same list for both that would be great.

[jlebel, 2017/06/19 07:07:49]

AndroidGATTStatusResult is definitely matching CBATTErrorDomain on macOS. But I
was trying to create one histogram per method which can receive an error, those
histograms were going to contain all possible errors. There is no guaranty about
the error domain that a method can receive.
I worked on CBErrorDomain and CBATTErrorDomain, but we could definitely receive
other domains. And we have to keep in mind the error code is unique per error
domain.
If I use Bluetooth.Web.Android, then I would have to create an histogram per
pair (method, error domain). I'm guessing some API are more likely to receive
errors about CBATTErrorDomain and others about CBErrorDomain. But I see nothing
related to that in Apple's doc.

+<!-- Name completed by histogram_suffixes name="WebBluetoothMacOSAPIs" -->
+  <owner>jlebel@chromium.org</owner>

[ortuno, 2017/05/31 06:59:52]

Add scheib@chromium.org or maybe just web-bluetooth@chromium.org.

scheib: Thoughts? Is there a more general mailing list that will always be
monitored?

[scheib, 2017/05/31 16:17:19]

How about scheib@chromium.org and device-dev@chromium.org

[jlebel, 2017/06/13 22:31:37]

Done.

+  <summary>
+    Records how many times each macOS GATT error has occured. The results will
+    be used to determine how commun this errors are and if we need to provide
+    better error messages to the users.
+  </summary>
+</histogram>
+
 <histogram name="Bluetooth.Web.RequestDevice.Filters.Count" units="filters">
   <owner>jyasskin@chromium.org</owner>
   <owner>ortuno@chromium.org</owner>
@@ -94151,6 +94161,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <affected-histogram name="WebApk.ShellApkVersion"/>
 </histogram_suffixes>
 
+<histogram_suffises name="WebBluetoothMacOSAPIs" separator=".">

[ortuno, 2017/05/31 06:59:52]

I think you mean suffixes instead of suffises.

[jlebel, 2017/06/13 22:31:37]

Done.

+	<suffix name="DidFailToConnectToPeripheral" label="Failed to connect to peripheral"/>
+	<suffix name="DidDisconnectPeripheral" label="Disconnected from peripheral"/>
+	<suffix name="DidDiscoverPrimaryServices" label="Discovered primary services"/>
+	<suffix name="DidDiscoverCharacteristics" label="Discovered characteristics"/>
+	<suffix name="DidUpdateValue" label="Updated value"/>
+	<suffix name="DidWriteValue" label="Wrote value value"/>
+	<suffix name="DidUpdateNotificationState" label="Updated notification state"/>
+	<suffix name="DidDiscoverDescriptors" label="Discovered descriptors"/>
+	<suffix name="DidUpdateValueForDescriptor" label="Updated value for descriptor"/>
+	<suffix name="DidWriteValueForDescriptor" label="Wrote value value for descriptor"/>
+	<affected-histogram name="Bluetooth.Web.MacOS.Errors"/>
+</histogram_suffises>
+
 <histogram_suffixes name="WebFontFamily" separator="_">
   <suffix name="roboto" label="Roboto font"/>
   <suffix name="opensans" label="Open Sans font"/>