Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 291263002: ServiceWorker: Strip fragment from scope and script URLs (Closed)

Created:
6 years, 7 months ago by jsbell
Modified:
6 years, 7 months ago
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Strip fragment identifier from scope and script URLs Since the fragment is not sent to the server, it can't be matched by the scope anyway. BUG=375422 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174610

Patch Set 1 #

Patch Set 2 : Test case for query in scope #

Total comments: 2

Patch Set 3 : Rebase the non-virtual result #

Patch Set 4 : Make normalizeURL remove fragment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M LayoutTests/http/tests/serviceworker/resources/test-helpers.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerobject-scope-expected.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/virtual/serviceworker/http/tests/serviceworker/serviceworkerobject-scope-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jsbell
Anyone? Not urgent, but trivial
6 years, 7 months ago (2014-05-20 20:18:54 UTC) #1
jsbell
Setting an actual reviewer field. Anyone - R? CQ?
6 years, 7 months ago (2014-05-20 23:58:50 UTC) #2
kinuko
lgtm
6 years, 7 months ago (2014-05-21 03:36:46 UTC) #3
kinuko
https://codereview.chromium.org/291263002/diff/20001/LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html File LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html (right): https://codereview.chromium.org/291263002/diff/20001/LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html#newcode20 LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html:20: expectedURL = expectedURL.replace(/#.*$/, ''); It might be good to ...
6 years, 7 months ago (2014-05-21 03:37:15 UTC) #4
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 7 months ago (2014-05-21 03:37:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/291263002/20001
6 years, 7 months ago (2014-05-21 03:38:15 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 09:39:41 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 05:57:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 06:40:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/8570)
6 years, 7 months ago (2014-05-22 06:40:21 UTC) #10
jsbell
https://codereview.chromium.org/291263002/diff/20001/LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html File LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html (right): https://codereview.chromium.org/291263002/diff/20001/LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html#newcode20 LayoutTests/http/tests/serviceworker/serviceworkerobject-scope.html:20: expectedURL = expectedURL.replace(/#.*$/, ''); On 2014/05/21 03:37:15, kinuko wrote: ...
6 years, 7 months ago (2014-05-22 16:49:05 UTC) #11
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 7 months ago (2014-05-22 16:49:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/291263002/60001
6 years, 7 months ago (2014-05-22 16:50:13 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 00:26:30 UTC) #14
Message was sent while issue was closed.
Change committed as 174610

Powered by Google App Engine
This is Rietveld 408576698