third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js - Issue 2912593003: [ServiceWorker] Fix bugs of wpt tests for Client.navigate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js

Issue 2912593003: [ServiceWorker] Fix bugs of wpt tests for Client.navigate (Closed)

Patch Set: Address comments from falken@ Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/dom/custom/svg-use-shadow-tree-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js

diff --git a/third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js b/third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js

index bb63e02caf72d48b6151ccfd24f68c24598f0d08..0e6f7608c0f8f6860a6a9a0d880e376158322d5f 100644

--- a/third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js

+++ b/third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js

@@ -483,7 +483,10 @@ policies and contribution forms [3].

}

function is_service_worker(worker) {

- return 'ServiceWorker' in self && worker instanceof ServiceWorker;

+ // The worker object may be from another execution context,

+ // so do not use instanceof here.

+ return 'ServiceWorker' in self &&

+ Object.prototype.toString.call(worker) == '[object ServiceWorker]';

}