third_party/WebKit/LayoutTests/resources/testharness.js - Issue 2912593003: [ServiceWorker] Fix bugs of wpt tests for Client.navigate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/resources/testharness.js

Issue 2912593003: [ServiceWorker] Fix bugs of wpt tests for Client.navigate (Closed)

Patch Set: Fix other tests influnced by changes of testharness.js Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/resources/testharness.js

diff --git a/third_party/WebKit/LayoutTests/resources/testharness.js b/third_party/WebKit/LayoutTests/resources/testharness.js

index 73913d6d32c3178be1a33d9c3a534afd8bbdffce..165a17f346d7fecb960458e722e382253fd4beef 100644

--- a/third_party/WebKit/LayoutTests/resources/testharness.js

+++ b/third_party/WebKit/LayoutTests/resources/testharness.js

@@ -483,7 +483,10 @@ policies and contribution forms [3].

}

function is_service_worker(worker) {

- return 'ServiceWorker' in self && worker instanceof ServiceWorker;

+ // The worker object may be from other execution context,

falken 2017/05/29 01:07:04 s/other/another

leonhsl(Using Gerrit) 2017/05/29 13:09:54 Acknowledged.

leonhsl(Using Gerrit) 2017/06/10 02:57:44 Done.

+ // so do not use instanceof here.

+ return 'ServiceWorker' in self &&

+ Object.prototype.toString.call(worker) == '[object ServiceWorker]';

}