[ServiceWorker] Fix bugs of wpt tests for Client.navigate

third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js

 /*global self*/
 /*jshint latedef: nofunc*/
 /*
 Distributed under both the W3C Test Suite License [1] and the W3C
 3-clause BSD License [2]. To contribute to a W3C Test Suite, see the
 policies and contribution forms [3].
 
 [1] http://www.w3.org/Consortium/Legal/2008/04-testsuite-license
 [2] http://www.w3.org/Consortium/Legal/2008/03-bsd-license
 [3] http://www.w3.org/2004/10/27-testcases
@@ skipping 465 matching lines @@
         throw new Error("Unsupported test environment");
     }
 
     var test_environment = create_test_environment();
 
     function is_shared_worker(worker) {
         return 'SharedWorker' in self && worker instanceof SharedWorker;
     }
 
     function is_service_worker(worker) {
-        return 'ServiceWorker' in self && worker instanceof ServiceWorker;
+        // The worker object may be from other execution context,

[falken, 2017/05/29 01:07:04]

s/other/another

[leonhsl(Using Gerrit), 2017/05/29 13:09:54]

Acknowledged.

[leonhsl(Using Gerrit), 2017/06/10 02:57:44]

Done.

+        // so do not use instanceof here.
+        return 'ServiceWorker' in self &&
+            Object.prototype.toString.call(worker) == '[object ServiceWorker]';

[leonhsl(Using Gerrit), 2017/05/28 09:12:59]

Another optional solution without changing testharness.js here:
Change client-navigate.https.html to pass reg.installing instead of
frame.contentWindow.navigator.serviceWorker.controller as sw object when calling
fetch_tests_from_worker(sw). 

I'd prefer to change is_service_worker() here.

[Mike West, 2017/05/29 08:02:44]

I'm not sure we can do that via this update mechanism, both because it's in a
separate repository, and because I'm not sure whether folks are on board with
individual vendors changing central infrastructure without cross-org review.
+foolip@ who will know whether we can upstream changes to `testharness.js` this
way.

     }
 
     /*
      * API functions
      */
 
     function test(func, name, properties)
     {
         var test_name = name ? name : test_environment.next_default_test_name();
         properties = properties ? properties : {};
@@ skipping 2288 matching lines @@
         done();
     };
 
     addEventListener("error", error_handler, false);
     addEventListener("unhandledrejection", function(e){ error_handler(e.reason); }, false);
 
     test_environment.on_tests_ready();
 
 })();
 // vim: set expandtab shiftwidth=4 tabstop=4: