Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3506)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js

Issue 2912593002: Create OOBE screen for Voice Interaction value proposition (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js b/chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js
new file mode 100644
index 0000000000000000000000000000000000000000..68576761d6094c42f7930bd98dd81c41164deb53
--- /dev/null
+++ b/chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js
@@ -0,0 +1,31 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview Polymer element for displaying material design voice
+ * interaction value prop screen.
+ */
+
+Polymer({
+ is: 'oobe-voice-interaction-value-prop-md',
+ /**
xc 2017/05/31 18:37:52 nit: newline above
yueli 2017/06/02 02:03:47 Done.
+ * On-tap event handler for no thanks button.
+ *
+ * @private
+ */
+ onNoThanksTap_: function() {
+ chrome.send('login.VoiceInteractionValuePropScreen.userActed',
xiyuan 2017/05/30 19:26:22 Existing polymer elements are firing events to let
yueli 2017/06/02 02:03:47 Seems the use pattern is mixed -- some polymer ele
xiyuan 2017/06/02 22:12:33 I would argue that chrome.send and the messages se
+ ['no-thanks-pressed']);
+ },
+
+ /**
+ * On-tap event handler for continue button.
+ *
+ * @private
+ */
+ onContinueTap_: function() {
+ chrome.send('login.VoiceInteractionValuePropScreen.userActed',
+ ['continue-pressed']);
+ },
+});

Powered by Google App Engine
This is Rietveld 408576698