Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js

Issue 2912593002: Create OOBE screen for Voice Interaction value proposition (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 /**
6 * @fileoverview Polymer element for displaying material design voice
7 * interaction value prop screen.
8 */
9
10 Polymer({
11 is: 'oobe-voice-interaction-value-prop-md',
12 /**
xc 2017/05/31 18:37:52 nit: newline above
yueli 2017/06/02 02:03:47 Done.
13 * On-tap event handler for no thanks button.
14 *
15 * @private
16 */
17 onNoThanksTap_: function() {
18 chrome.send('login.VoiceInteractionValuePropScreen.userActed',
xiyuan 2017/05/30 19:26:22 Existing polymer elements are firing events to let
yueli 2017/06/02 02:03:47 Seems the use pattern is mixed -- some polymer ele
xiyuan 2017/06/02 22:12:33 I would argue that chrome.send and the messages se
19 ['no-thanks-pressed']);
20 },
21
22 /**
23 * On-tap event handler for continue button.
24 *
25 * @private
26 */
27 onContinueTap_: function() {
28 chrome.send('login.VoiceInteractionValuePropScreen.userActed',
29 ['continue-pressed']);
30 },
31 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698