chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.html - Issue 2912593002: Create OOBE screen for Voice Interaction value proposition

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.html

Issue 2912593002: Create OOBE screen for Voice Interaction value proposition (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/chromeos/login/oobe_screen_voice_interaction_value_prop.js ('K') | « chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.css ('k') | chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js » ('j') | chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	2 Use of this source code is governed by a BSD-style license that can be

	3 found in the LICENSE file. -->

	4

	5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	6

	7 <dom-module id="oobe-voice-interaction-value-prop-md">

	8 <template>

	9 <link rel="stylesheet" href="oobe_voice_interaction_value_prop.css">

	10 <link rel="stylesheet" href="oobe_dialog_parameters.css">

	11 <oobe-dialog id="voiceInteractionValuePropDialog" role="dialog" hide-shadow

	12 has-buttons no-footer>

	13 <div class = "header">

	14 <webview id="valueView" src="https://www.gstatic.com/opa-chromeos/oobe/e n/value_proposition.html"></webview>
	xiyuan 2017/05/30 19:26:22 nit: valueView -> value-id to follow existing styl nit: valueView -> value-id to follow existing style xiyuan 2017/05/30 19:26:22 Think we need to - use a proper url for locales ot Think we need to - use a proper url for locales other than en; - handle load error; - clicking on the links inside the webview to ensure it does not become a browser; xc 2017/05/31 18:37:52 Yue should be replacing "en" with proper locales. Show quoted text > - use a proper url for locales other than en; Yue should be replacing "en" with proper locales. But is there some conventions to handle i18n for gstatic? currently the other team provided only language specific directories yueli 2017/06/02 02:03:47 How should I disable links in webview? Show quoted text On 2017/05/30 19:26:22, xiyuan wrote: > Think we need to > - use a proper url for locales other than en; > - handle load error; > - clicking on the links inside the webview to ensure it does not become a > browser; How should I disable links in webview? yueli 2017/06/02 02:03:47 Done. Show quoted text On 2017/05/30 19:26:22, xiyuan wrote: > nit: valueView -> value-id to follow existing style Done. xiyuan 2017/06/02 22:12:33 webview.addContentScripts can inject script that r Show quoted text On 2017/06/02 02:03:47, yueli wrote: > On 2017/05/30 19:26:22, xiyuan wrote: > > Think we need to > > - use a proper url for locales other than en; > > - handle load error; > > - clicking on the links inside the webview to ensure it does not become a > > browser; > > How should I disable links in webview? webview.addContentScripts can inject script that runs in the loaded document. For now, we can do a simple stripping after document is loaded. Something like: webview.addContentScripts([ { name: 'stripLinks', matches: ['<all_urls>'], js: { code: "document.querySelectorAll('a').forEach(function(anchor){anchor.href='javascript:void(0)';})" }, run_at: 'document_end' }]); yueli 2017/06/07 18:31:49 Done. Show quoted text On 2017/06/02 22:12:33, xiyuan wrote: > On 2017/06/02 02:03:47, yueli wrote: > > On 2017/05/30 19:26:22, xiyuan wrote: > > > Think we need to > > > - use a proper url for locales other than en; > > > - handle load error; > > > - clicking on the links inside the webview to ensure it does not become a > > > browser; > > > > How should I disable links in webview? > > webview.addContentScripts can inject script that runs in the loaded document. > For now, we can do a simple stripping after document is loaded. > > Something like: > > webview.addContentScripts([ > { > name: 'stripLinks', > matches: ['<all_urls>'], > js: { code: > "document.querySelectorAll('a').forEach(function(anchor){anchor.href='javascript:void(0)';})" > }, > run_at: 'document_end' > }]); Done.
	15 </div>

	16 <div class="bottom-buttons flex layout horizontal">

	17 <div class="flex"></div>

	18 <oobe-text-button id="noThanksButton" border on-tap="onNoThanksTap_">

	19 <div i18n-content="voiceInteractionValuePropNoThanksButton"></div>

	20 </oobe-text-button>

	21 <oobe-text-button inverse on-tap="onContinueTap_">

	22 <div i18n-content="voiceInteractionValuePropContinueButton"></div>

	23 </oobe-text-button>

	24 </div>

	25 </oobe-dialog>

	26 </template>

	27 </dom-module>

OLD	NEW