Create OOBE screen for Voice Interaction value proposition

chrome/browser/chromeos/first_run/first_run.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/first_run/first_run_controller.h"
@@ skipping 27 matching lines @@
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
   if (!service)
     return;
 
   const extensions::Extension* extension =
       service->GetExtensionById(extension_misc::kFirstRunDialogId, false);
   if (!extension)
     return;
 
+  // If voice interaction value prop has been accepted, the tutorial will be
+  // shown after the voice interaction OOBE flow.
+  if (profile->GetPrefs()->GetBoolean(
+          prefs::kArcVoiceInteractionValuePropAccepted))

[xiyuan, 2017/05/30 19:26:21]

How would this play along with MaybeLaunchDialogAfterSessionStart() and
MaybeLaunchDialogImmediately() ? I wonder whether we should do the skipping at
where those two calls are made instead of here.

[xc, 2017/05/31 18:37:52]

+1 We may have to show this more than once even if user accepted it, e.g. user
accepted the value prop but declined the UDC later. 

[yueli, 2017/06/02 02:03:46]

Done.

+    return;
+
   OpenApplication(AppLaunchParams(
       profile, extension, extensions::LAUNCH_CONTAINER_WINDOW,
       WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_CHROME_INTERNAL));
   profile->GetPrefs()->SetBoolean(prefs::kFirstRunTutorialShown, true);
 }
 
 void TryLaunchFirstRunDialog(Profile* profile) {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
 
   if (command_line->HasSwitch(switches::kOobeSkipPostLogin))
@@ skipping 74 matching lines @@
       user_manager::UserManager::Get()->GetActiveUser()));
 }
 
 void LaunchTutorial() {
   UMA_HISTOGRAM_BOOLEAN("CrosFirstRun.TutorialLaunched", true);
   FirstRunController::Start();
 }
 
 }  // namespace first_run
 }  // namespace chromeos