Issue 2912563002: Revert "Revert "Revert "Refactor test option parsing code."""

Issue 2912563002: Revert "Revert "Revert "Refactor test option parsing code.""" (Closed)

Created:
3 years, 7 months ago by Bob Nystrom

Modified:
3 years, 7 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Revert "Revert "Refactor test option parsing code.""" This reverts commit 79af4184306a568ee8f006b9f0eaeab6ebae7750. Committed: https://github.com/dart-lang/sdk/commit/02547656ccb1b9b5e349ad0ac81459cb725cb125

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1048 lines, -940 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	samples/samples.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/testing/dart/co19_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/compiler_configuration.dart	View	12 chunks	+15 lines, -14 lines	0 comments	Download
M	tools/testing/dart/main.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	tools/testing/dart/options.dart	View	1 chunk	+0 lines, -916 lines	0 comments	Download
M	tools/testing/dart/package_testing_support.dart	View	1 chunk	+6 lines, -4 lines	0 comments	Download
A	tools/testing/dart/test_options.dart	View	1 chunk	+1012 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

Committed patchset #1 (id:1) manually as 02547656ccb1b9b5e349ad0ac81459cb725cb125 (presubmit successful).

3 years, 7 months ago (2017-05-26 21:46:09 UTC) #4

Message was sent while issue was closed.

YO DAWG.
lgtm. alas. :-(