Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2912473004: [MD settings] rename lastRoutChangeWasPopstate var (Closed)
Patch Set: updated test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_page/main_page_behavior.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/route.js
diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js
index 502715254260b4b80a111ba69bde0127d2002afc..b675fc89fd823ad9685598344cba88de5f88d696 100644
--- a/chrome/browser/resources/settings/route.js
+++ b/chrome/browser/resources/settings/route.js
@@ -308,7 +308,7 @@ cr.define('settings', function() {
var currentQueryParameters = new URLSearchParams();
/** @private {boolean} */
- var lastRouteChangeWasPopstate_ = false;
+ var wasLastRouteChangePopstate = false;
/** @private */
var initializeRouteFromUrlCalled = false;
@@ -332,7 +332,7 @@ cr.define('settings', function() {
function resetRouteForTesting() {
initializeRouteFromUrlCalled = false;
- lastRouteChangeWasPopstate_ = false;
+ wasLastRouteChangePopstate = false;
currentRoute = Route.BASIC;
currentQueryParameters = new URLSearchParams();
}
@@ -347,7 +347,7 @@ cr.define('settings', function() {
var oldRoute = currentRoute;
currentRoute = route;
currentQueryParameters = queryParameters;
- lastRouteChangeWasPopstate_ = isPopstate;
+ wasLastRouteChangePopstate = isPopstate;
routeObservers.forEach(function(observer) {
observer.currentRouteChanged(currentRoute, oldRoute);
});
@@ -363,7 +363,7 @@ cr.define('settings', function() {
/** @return {boolean} */
var lastRouteChangeWasPopstate = function() {
- return lastRouteChangeWasPopstate_;
+ return wasLastRouteChangePopstate;
};
/**
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_page/main_page_behavior.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698