Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: chrome/test/data/webui/settings/route_tests.js

Issue 2912473004: [MD settings] rename lastRoutChangeWasPopstate var (Closed)
Patch Set: swapped names Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/route_tests.js
diff --git a/chrome/test/data/webui/settings/route_tests.js b/chrome/test/data/webui/settings/route_tests.js
index ab0c682e3a658ccae27c3b1087d02f9ff1e0a88e..9733d6311c0aac0bb34c330643c3c6caf4f28cef 100644
--- a/chrome/test/data/webui/settings/route_tests.js
+++ b/chrome/test/data/webui/settings/route_tests.js
@@ -151,19 +151,19 @@ suite('route', function() {
test('popstate flag works', function() {
settings.navigateTo(settings.Route.BASIC);
- assertFalse(settings.lastRouteChangeWasPopstate());
+ assertFalse(settings.wasLastRouteChangePopstate());
dpapad 2017/05/27 01:29:51 This file should be reverted too, since this funct
dschuyler 2017/05/27 01:35:36 Thanks for catching this!
settings.navigateTo(settings.Route.PEOPLE);
- assertFalse(settings.lastRouteChangeWasPopstate());
+ assertFalse(settings.wasLastRouteChangePopstate());
return whenPopState(function() {
window.history.back();
}).then(function() {
assertEquals(settings.Route.BASIC, settings.getCurrentRoute());
- assertTrue(settings.lastRouteChangeWasPopstate());
+ assertTrue(settings.wasLastRouteChangePopstate());
settings.navigateTo(settings.Route.ADVANCED);
- assertFalse(settings.lastRouteChangeWasPopstate());
+ assertFalse(settings.wasLastRouteChangePopstate());
});
});

Powered by Google App Engine
This is Rietveld 408576698