[MD settings] rename lastRoutChangeWasPopstate var

chrome/browser/resources/settings/route.js

Index: chrome/browser/resources/settings/route.js
diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js
index 502715254260b4b80a111ba69bde0127d2002afc..5c4cfff14da826d83ab9607231e0adf703405ad2 100644
--- a/chrome/browser/resources/settings/route.js
+++ b/chrome/browser/resources/settings/route.js
@@ -308,7 +308,7 @@ cr.define('settings', function() {
   var currentQueryParameters = new URLSearchParams();
 
   /** @private {boolean} */
-  var lastRouteChangeWasPopstate_ = false;
+  var lastRouteChangeWasPopstate = false;
 
   /** @private */
   var initializeRouteFromUrlCalled = false;
@@ -332,7 +332,7 @@ cr.define('settings', function() {
 
   function resetRouteForTesting() {
     initializeRouteFromUrlCalled = false;
-    lastRouteChangeWasPopstate_ = false;
+    lastRouteChangeWasPopstate = false;
     currentRoute = Route.BASIC;
     currentQueryParameters = new URLSearchParams();
   }
@@ -347,7 +347,7 @@ cr.define('settings', function() {
     var oldRoute = currentRoute;
     currentRoute = route;
     currentQueryParameters = queryParameters;
-    lastRouteChangeWasPopstate_ = isPopstate;
+    lastRouteChangeWasPopstate = isPopstate;
     routeObservers.forEach(function(observer) {
       observer.currentRouteChanged(currentRoute, oldRoute);
     });
@@ -362,8 +362,8 @@ cr.define('settings', function() {
   };
 
   /** @return {boolean} */
-  var lastRouteChangeWasPopstate = function() {
-    return lastRouteChangeWasPopstate_;
+  var wasLastRouteChangePopstate = function() {

[dpapad, 2017/05/27 00:25:56]

My understanding is that you are forced to rename this method, otherwise it will
collide with the new name of of the boolean variable.

If that's accurate, how about going the reverse direction?

lastRouteChangeWasPopstate_ -> wasLastRouteChangePopstate
lastRouteChangeWasPopstate  -> No need to change, stays the same

This would produces a smaller diff, which is the only way I am suggesting it.

[dschuyler, 2017/05/27 01:16:36]

Done.

+    return lastRouteChangeWasPopstate;
   };

[dschuyler, 2017/05/26 23:29:59]

I'm tempted to remove this function entirely and allow access to the variable.
WDYT?

[dpapad, 2017/05/27 00:25:56]

It seems that this would break the intention of the existing code, which is to
allow read access, but not write access.

[dschuyler, 2017/05/27 01:16:36]

Acknowledged.

 
   /**
@@ -429,7 +429,7 @@ cr.define('settings', function() {
     resetRouteForTesting: resetRouteForTesting,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
-    lastRouteChangeWasPopstate: lastRouteChangeWasPopstate,
+    wasLastRouteChangePopstate: wasLastRouteChangePopstate,
     navigateTo: navigateTo,
     navigateToPreviousRoute: navigateToPreviousRoute,
   };