Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2912473002: Fix an IME bug where RWHImpl::ImeFinishCompositingText is called twice in a row (Closed)
Patch Set: Change EXPECT_EQ => ASSERT_EQ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_event_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 70dd0dc4e109756f7e471a7e42eb7b5934a1ef3c..b6c9b0d4ed86d1b2f17450bded94b640673fe236 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -1568,15 +1568,12 @@ TEST_F(RenderWidgetHostViewAuraTest, FinishCompositionByMouse) {
EXPECT_FALSE(view_->has_composition_text_);
- EXPECT_EQ(2U, sink_->message_count());
+ ASSERT_EQ(2U, sink_->message_count());
- if (sink_->message_count() == 2) {
- // Verify mouse event happens after the finish composing text event.
- EXPECT_EQ(InputMsg_ImeFinishComposingText::ID,
- sink_->GetMessageAt(0)->type());
- EXPECT_EQ(InputMsg_HandleInputEvent::ID,
- sink_->GetMessageAt(1)->type());
- }
+ // Verify mouse event happens after the finish composing text event.
+ EXPECT_EQ(InputMsg_ImeFinishComposingText::ID,
+ sink_->GetMessageAt(0)->type());
+ EXPECT_EQ(InputMsg_HandleInputEvent::ID, sink_->GetMessageAt(1)->type());
}
// Checks that touch-event state is maintained correctly.
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_event_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698