Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2912433002: Fix race in base::Timer when SetTaskRunner() is used

Created:
3 years, 7 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, danakj+watch_chromium.org, chirantan+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix race in base::Timer when SetTaskRunner() is used Effectively reverting back to patch set 32 of https://codereview.chromium.org/2491613004/ which had to land without fixing the pre-existing race per the race proving harder than expected to fix and not being worsened by that CL. BUG=587199

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -35 lines) Patch
M base/timer/timer.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M base/timer/timer.cc View 1 4 chunks +13 lines, -26 lines 0 comments Download
M build/sanitizers/tsan_suppressions.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (4 generated)
gab
The CQ bit was checked by gab@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 05:26:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912433002/1
3 years, 7 months ago (2017-05-26 05:27:05 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-26 06:31:36 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 06:31:36 UTC) #4
Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698