IndexedDB: Test updates for store/index deletion race

LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js

 if (this.importScripts) {
     importScripts('../../../resources/js-test.js');
     importScripts('shared.js');
 }
 
 description("Test IndexedDB's basics.");
 
 indexedDBTest(prepareDatabase);
 function prepareDatabase(event)
 {
@@ skipping 12 matching lines @@
     // This will asynchronously abort in the backend because of constraint failures.
     evalAndLog("objectStore.createIndex('index', 'key', {unique: true})");
     // Now immediately delete it.
     evalAndLog("objectStore.deleteIndex('index')");
     // Delete it again: backend may have asynchronously aborted the
     // index creation, but this makes sure the frontend doesn't get
     // confused and crash, or think the index still exists.
     evalAndExpectException("objectStore.deleteIndex('index')", "DOMException.NOT_FOUND_ERR", "'NotFoundError'");
     debug("Now requesting object2");
     var req3 = objectStore.get("object2");
-    req3.onsuccess = deleteIndexAfterGet;
-    req3.onerror = unexpectedErrorCallback;
+    req3.onsuccess = unexpectedSuccessCallback;
+    req3.onerror = deleteIndexAfterGetError;
     debug("now we wait.");
 }
 
-function deleteIndexAfterGet() {
-    // so we will delete it next, but it should already be gone... right?
-    debug("deleteIndexAfterGet()");
+function deleteIndexAfterGetError() {
+    debug("deleteIndexAfterGetError()");
     // the index should still be gone, and this should not crash.
-    evalAndExpectException("objectStore.deleteIndex('index')", "DOMException.NOT_FOUND_ERR", "'NotFoundError'");
-    evalAndExpectException("objectStore.deleteIndex('index')", "DOMException.NOT_FOUND_ERR", "'NotFoundError'");
+    evalAndExpectException("objectStore.deleteIndex('index')", "0", "'TransactionInactiveError'");

[cmumford, 2014/05/23 19:57:20]

Just curious: why two calls to deleteIndex?

[jsbell, 2014/05/23 20:09:10]

I believe this test started life as a regression test for a crash triggered by a
second deleteIndex(). It's in the initial commit of the test and no comment, so
it's hard to tell.

+    evalAndExpectException("objectStore.deleteIndex('index')", "0", "'TransactionInactiveError'");
 
     finishJSTest();
-}
+}