Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 291243003: IndexedDB: Test updates for store/index deletion race (Closed)

Created:
6 years, 7 months ago by jsbell
Modified:
6 years, 7 months ago
Reviewers:
ericu, cmumford
CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford
Visibility:
Public.

Description

IndexedDB: Test updates for store/index deletion race Follow-up to https://codereview.chromium.org/277583002 to rework test and add new one. createIndex-after-failure.html now matches FF behavior. BUG=370056, 368271 TBR=ericu@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174727

Patch Set 1 #

Patch Set 2 : Enable tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -27 lines) Patch
M LayoutTests/TestExpectations View 1 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
A + LayoutTests/storage/indexeddb/createObjectStore-put-deleteObjectStore.html View 2 chunks +3 lines, -7 lines 0 comments Download
A + LayoutTests/storage/indexeddb/createObjectStore-put-deleteObjectStore-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js View 1 chunk +7 lines, -8 lines 2 comments Download

Messages

Total messages: 12 (0 generated)
jsbell
cmumford@ - please take a look?
6 years, 7 months ago (2014-05-23 19:18:49 UTC) #1
cmumford
lgtm https://codereview.chromium.org/291243003/diff/20001/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js File LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js (right): https://codereview.chromium.org/291243003/diff/20001/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js#newcode41 LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js:41: evalAndExpectException("objectStore.deleteIndex('index')", "0", "'TransactionInactiveError'"); Just curious: why two calls ...
6 years, 7 months ago (2014-05-23 19:57:20 UTC) #2
jsbell
https://codereview.chromium.org/291243003/diff/20001/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js File LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js (right): https://codereview.chromium.org/291243003/diff/20001/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js#newcode41 LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js:41: evalAndExpectException("objectStore.deleteIndex('index')", "0", "'TransactionInactiveError'"); On 2014/05/23 19:57:20, cmumford wrote: > ...
6 years, 7 months ago (2014-05-23 20:09:10 UTC) #3
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 7 months ago (2014-05-23 20:09:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/291243003/20001
6 years, 7 months ago (2014-05-23 20:09:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 20:09:30 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-23 20:09:31 UTC) #7
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 7 months ago (2014-05-23 20:54:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/291243003/20001
6 years, 7 months ago (2014-05-23 20:55:27 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 22:13:32 UTC) #10
commit-bot: I haz the power
Change committed as 174727
6 years, 7 months ago (2014-05-23 23:01:30 UTC) #11
ericu
6 years, 7 months ago (2014-05-27 21:21:44 UTC) #12
Message was sent while issue was closed.
LGTM2

Powered by Google App Engine
This is Rietveld 408576698