Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 291243002: Never ignore HTMLLabelElement's click() calls (Closed)

Created:
6 years, 7 months ago by Xianzhu
Modified:
6 years, 7 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Visibility:
Public.

Description

Never ignore HTMLLabelElement's click() calls Programatic HTMLElement::click() is expected to execute the activation behavior of the element. For label element, it should always trigger the target control's click behavior even if the label is selected. BUG=375358 TEST=fast/events/label-click.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174613

Patch Set 1 #

Total comments: 8

Patch Set 2 : For landing #

Patch Set 3 : Fix test #

Patch Set 4 : Click may be not a mouse event #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -4 lines) Patch
A LayoutTests/fast/forms/label/label-click.html View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/label/label-click-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Xianzhu
6 years, 7 months ago (2014-05-20 18:36:07 UTC) #1
tkent
lgtm https://codereview.chromium.org/291243002/diff/1/LayoutTests/fast/events/label-click.html File LayoutTests/fast/events/label-click.html (right): https://codereview.chromium.org/291243002/diff/1/LayoutTests/fast/events/label-click.html#newcode1 LayoutTests/fast/events/label-click.html:1: <!DOCTYPE html> The test is <label>-specific. I prefer ...
6 years, 7 months ago (2014-05-21 00:35:49 UTC) #2
Xianzhu
https://codereview.chromium.org/291243002/diff/1/LayoutTests/fast/events/label-click.html File LayoutTests/fast/events/label-click.html (right): https://codereview.chromium.org/291243002/diff/1/LayoutTests/fast/events/label-click.html#newcode1 LayoutTests/fast/events/label-click.html:1: <!DOCTYPE html> On 2014/05/21 00:35:49, tkent wrote: > The ...
6 years, 7 months ago (2014-05-21 15:58:53 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-21 15:58:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/291243002/20001
6 years, 7 months ago (2014-05-21 17:50:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 23:54:41 UTC) #6
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-22 00:12:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/291243002/30001
6 years, 7 months ago (2014-05-22 00:13:47 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 12:15:32 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 12:16:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9698)
6 years, 7 months ago (2014-05-22 12:16:46 UTC) #11
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-22 19:35:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/291243002/30001
6 years, 7 months ago (2014-05-22 19:36:13 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 22:06:27 UTC) #14
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-22 22:36:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/291243002/50001
6 years, 7 months ago (2014-05-22 22:37:03 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 00:27:47 UTC) #17
Message was sent while issue was closed. 
Change committed as 174613

Powered by Google App Engine
This is Rietveld 408576698