Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3042)

Unified Diff: chrome/android/webapk/strings/android_webapk_strings.grd

Issue 2912393005: Add support for webapk without runtimeHost (part 2) (Closed)
Patch Set: pkotwicz@'s comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/strings/android_webapk_strings.grd
diff --git a/chrome/android/webapk/strings/android_webapk_strings.grd b/chrome/android/webapk/strings/android_webapk_strings.grd
index 0f131e56472e66d91aef3ac11a25378152bab42a..67b790c3ea7a6753b9b831aa678f9b36e3642c4f 100644
--- a/chrome/android/webapk/strings/android_webapk_strings.grd
+++ b/chrome/android/webapk/strings/android_webapk_strings.grd
@@ -103,6 +103,12 @@
<message name="IDS_CHOOSE_HOST_BROWSER_DIALOG_QUIT" desc="Text for the cancel button on the dialog. ">
QUIT
</message>
+ <message name="IDS_INSTALL_HOST_BROWSER_DIALOG_TITLE" desc="Title for the dialog to install the host browser to launch the WebAPK.">
+ <ph name="WEBAPK_SITE">%1$s<ex>Housing.com</ex></ph> needs the following app to run
+ </message>
+ <message name="IDS_INSTALL_HOST_BROWSER_DIALOG_INSTALL_BUTTON" desc="Text for the install button on the dialog. ">
+ INSTALL
pkotwicz 2017/06/05 19:18:20 Is it necessary to make these uppercase? Will Andr
Xi Han 2017/06/06 15:12:28 In the Play Store, the green button of "INSTALL" i
pkotwicz 2017/06/06 15:21:47 I meant: Won't the Android framework make the word
Xi Han 2017/06/06 15:49:24 Yes, it is auto converted to uppercase. I still th
+ </message>
</messages>
</release>
</grit>

Powered by Google App Engine
This is Rietveld 408576698