Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2912393005: Add support for webapk without runtimeHost (part 2) (Closed)
Patch Set: pkotwicz@'s comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java » ('j') | chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/ChooseHostBrowserDialog.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 <issue id="IconColors" severity="Error"> 97 <issue id="IconColors" severity="Error">
98 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/not ification_icon.png"/> 98 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/not ification_icon.png"/>
99 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-mdpi/not ification_icon.png"/> 99 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-mdpi/not ification_icon.png"/>
100 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xhdpi/no tification_icon.png"/> 100 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xhdpi/no tification_icon.png"/>
101 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxhdpi/n otification_icon.png"/> 101 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxhdpi/n otification_icon.png"/>
102 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/ notification_icon.png"/> 102 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/ notification_icon.png"/>
103 </issue> 103 </issue>
104 <issue id="IconDensities"> 104 <issue id="IconDensities">
105 <!-- The large assets below only include a few densities to reduce APK size. --> 105 <!-- The large assets below only include a few densities to reduce APK size. -->
106 <ignore regexp=": data_reduction_illustration.png, physical_web_logo.png, ph ysical_web_logo_anim1.png, physical_web_logo_anim2.png$"/> 106 <ignore regexp=": data_reduction_illustration.png, physical_web_logo.png, ph ysical_web_logo_anim1.png, physical_web_logo_anim2.png$"/>
107 <ignore regexp="chrome/android/webapk/shell_apk/res/drawable-hdpi"/>
108 <ignore regexp="chrome/android/webapk/shell_apk/res/drawable-mdpi"/>
109 <ignore regexp="chrome/android/webapk/shell_apk/res/drawable-xhdpi"/>
110 <ignore regexp="chrome/android/webapk/shell_apk/res/drawable-xxhdpi"/>
107 <!-- crbug.com/457918 is tracking missing assets --> 111 <!-- crbug.com/457918 is tracking missing assets -->
108 <ignore regexp="chrome/android/java/res/drawable-xxhdpi"/> 112 <ignore regexp="chrome/android/java/res/drawable-xxhdpi"/>
109 <ignore regexp="chrome/android/java/res/drawable-xxxhdpi"/> 113 <ignore regexp="chrome/android/java/res/drawable-xxxhdpi"/>
110 <ignore regexp="chromecast/internal"/> 114 <ignore regexp="chromecast/internal"/>
111 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxhdpi"/> 115 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxhdpi"/>
112 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxxhdpi"/> 116 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxxhdpi"/>
113 <ignore regexp="content/public/android/java/res/drawable-xxhdpi"/> 117 <ignore regexp="content/public/android/java/res/drawable-xxhdpi"/>
114 <ignore regexp="content/public/android/java/res/drawable-xxxhdpi"/> 118 <ignore regexp="content/public/android/java/res/drawable-xxxhdpi"/>
115 <ignore regexp="ui/android/java/res/drawable-xxhdpi"/> 119 <ignore regexp="ui/android/java/res/drawable-xxhdpi"/>
116 <ignore regexp="ui/android/java/res/drawable-xxxhdpi"/> 120 <ignore regexp="ui/android/java/res/drawable-xxxhdpi"/>
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
463 <ignore regexp="chrome/android/javatests"/> 467 <ignore regexp="chrome/android/javatests"/>
464 <ignore regexp="/test/"/> 468 <ignore regexp="/test/"/>
465 </issue> 469 </issue>
466 <issue id="WrongCall" severity="ignore"/> 470 <issue id="WrongCall" severity="ignore"/>
467 <issue id="WrongConstant"> 471 <issue id="WrongConstant">
468 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 472 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
469 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorDialog.java"/> 473 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorDialog.java"/>
470 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 474 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
471 </issue> 475 </issue>
472 </lint> 476 </lint>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataKeys.java » ('j') | chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/ChooseHostBrowserDialog.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698