Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2912393004: Kernel/VM: Set the instantiator type arguments on closures (Closed)

Created:
3 years, 6 months ago by Kevin Millikin (Google)
Modified:
3 years, 6 months ago
Reviewers:
ahe, regis, kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kernel/VM: Set the instantiator type arguments on closures If a closure has uninstantiated type arguments from the enclosing class, set them on the freshly allocated closure. Closes issue #29409. BUG=https://github.com/dart-lang/sdk/issues/29409 R=kustermann@google.com, regis@google.com Committed: https://github.com/dart-lang/sdk/commit/1624c4f9c35998603a16380f03f457219d75c810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M runtime/vm/kernel_to_il.cc View 2 chunks +23 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 5 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Kevin Millikin (Google)
Peter: there are now some untriaged test failures, which I haven't looked at yet. Regis: ...
3 years, 6 months ago (2017-06-01 12:07:30 UTC) #2
ahe
Thank you, Kevin. It'll be interesting to see if I have fixed those new untriaged ...
3 years, 6 months ago (2017-06-01 12:09:23 UTC) #3
ahe
Thank you, Kevin. It'll be interesting to see if I have fixed those new untriaged ...
3 years, 6 months ago (2017-06-01 12:09:23 UTC) #4
kustermann
LGTM
3 years, 6 months ago (2017-06-01 12:23:18 UTC) #5
regis
LGTM
3 years, 6 months ago (2017-06-01 16:23:38 UTC) #6
Kevin Millikin (Google)
3 years, 6 months ago (2017-06-02 09:44:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1624c4f9c35998603a16380f03f457219d75c810 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698