Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: components/password_manager/core/browser/password_reuse_detector_unittest.cc

Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings. (Closed)
Patch Set: Fix deps Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_reuse_detector_unittest.cc
diff --git a/components/password_manager/core/browser/password_reuse_detector_unittest.cc b/components/password_manager/core/browser/password_reuse_detector_unittest.cc
index 94d2fa82665967e353f11145145f646ddc411f54..a5ecff957ec8b1172d810ee8f2978c2d61e8a3c5 100644
--- a/components/password_manager/core/browser/password_reuse_detector_unittest.cc
+++ b/components/password_manager/core/browser/password_reuse_detector_unittest.cc
@@ -14,6 +14,7 @@
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/testing_pref_service.h"
+#include "components/safe_browsing/common/safebrowsing_constants.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -209,8 +210,10 @@ TEST(PasswordReuseDetectorTest, SyncPasswordReuseFound) {
reuse_detector.SaveSyncPasswordHash(ASCIIToUTF16("sync_password"));
- EXPECT_CALL(mockConsumer, OnReuseFound(ASCIIToUTF16("sync_password"),
- "accounts.google.com", 1, 0));
+ EXPECT_CALL(
+ mockConsumer,
+ OnReuseFound(ASCIIToUTF16("sync_password"),
+ std::string(safe_browsing::kSyncPasswordDomain), 1, 0));
reuse_detector.CheckReuse(ASCIIToUTF16("sync_password"), "https://evil.com",
&mockConsumer);
}

Powered by Google App Engine
This is Rietveld 408576698