Issue 2912383003: Roll Dartium's buildtools to a version with valid DEPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2912383003: Roll Dartium's buildtools to a version with valid DEPS (Closed)

Created:
3 years, 6 months ago by Bill Hesse

Modified:
3 years, 6 months ago

Reviewers:
terry, ahe

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Roll Dartium's buildtools to a version with valid DEPS BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=727587 R=ahe@google.com, terry@google.com Committed: https://github.com/dart-lang/sdk/commit/499cb29c70ec381783360dd31d1f08461ea29960

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/deps/dartium.deps/DEPS	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

Bill Hesse

The gclient in depot_tools has started validating DEPS files, that they are not executing arbitrary ...

3 years, 6 months ago (2017-05-31 14:01:33 UTC) #2

Bill Hesse

3 years, 6 months ago (2017-05-31 14:11:59 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
499cb29c70ec381783360dd31d1f08461ea29960 (presubmit successful).