Add a path parsing policy handler for the RoamingProfileLocation policy.

chrome/browser/policy/local_sync_policy_handler_unittest.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.

[ljusten (tachyonic), 2017/06/01 10:05:53]

2017

[pastarmovj, 2017/06/01 11:05:06]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
+#include "chrome/browser/policy/local_sync_policy_handler.h"
+#include "components/policy/core/common/policy_map.h"
+#include "components/policy/core/common/policy_types.h"
+#include "components/policy/policy_constants.h"
+#include "components/prefs/pref_value_map.h"
+#include "components/sync/base/pref_names.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace policy {
+
+class LocalSyncPolicyTest : public testing::Test {
+ protected:
+  PolicyMap policy_;
+  LocalSyncPolicyHandler handler_;
+  PrefValueMap prefs_;
+};
+
+TEST_F(LocalSyncPolicyTest, Default) {
+  handler_.ApplyPolicySettings(policy_, &prefs_);
+  EXPECT_FALSE(prefs_.GetValue(syncer::prefs::kLocalSyncBackendDir, NULL));

[ljusten (tachyonic), 2017/06/01 10:05:53]

Nit: nullptr

[pastarmovj, 2017/06/01 11:05:06]

Done.

+}
+
+TEST_F(LocalSyncPolicyTest, SetPolicyInvalid) {
+  // RoamingProfileLocation policy expects a string; give it a boolean.

[ljusten (tachyonic), 2017/06/01 10:05:53]

Nit: I'd suggest to move this comment above TEST_F because it describes the
general idea of the test.

[pastarmovj, 2017/06/01 11:05:06]

Done.

+  policy_.Set(key::kRoamingProfileLocation, POLICY_LEVEL_MANDATORY,
+              POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+              base::MakeUnique<base::Value>(false), nullptr);

[ljusten (tachyonic), 2017/06/01 10:05:53]

Nit: nullptr /* external_data_fetcher */

[pastarmovj, 2017/06/01 11:05:06]

I don't think this is particularly useful comment.

+  handler_.ApplyPolicySettings(policy_, &prefs_);
+  EXPECT_FALSE(prefs_.GetValue(syncer::prefs::kLocalSyncBackendDir, NULL));

[ljusten (tachyonic), 2017/06/01 10:05:53]

Nit: nullptr

[pastarmovj, 2017/06/01 11:05:07]

Done.

+}
+
+TEST_F(LocalSyncPolicyTest, SetPolicyValid) {
+  // Use a variable in the value. It should be expanded by the handler.

[ljusten (tachyonic), 2017/06/01 10:05:53]

Same here.

[pastarmovj, 2017/06/01 11:05:06]

Done.

+  const std::string in = "${user_name}/foo";
+  policy_.Set(key::kRoamingProfileLocation, POLICY_LEVEL_MANDATORY,
+              POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+              base::MakeUnique<base::Value>(in), nullptr);

[ljusten (tachyonic), 2017/06/01 10:05:53]

Nit: nullptr /* external_data_fetcher */

[pastarmovj, 2017/06/01 11:05:06]

ditto.

+  handler_.ApplyPolicySettings(policy_, &prefs_);
+
+  const base::Value* value;
+  ASSERT_TRUE(prefs_.GetValue(syncer::prefs::kLocalSyncBackendDir, &value));
+  std::string out;
+  ASSERT_TRUE(value->GetAsString(&out));
+  EXPECT_NE(std::string::npos, out.find("foo"));
+  EXPECT_EQ(std::string::npos, out.find("${user_name}"));

[ljusten (tachyonic), 2017/06/01 10:05:53]

Is it possible to check whether ${user_name} was replaced by the actual user
name?

[pastarmovj, 2017/06/01 11:05:06]

Not really in a platform independent way. It is important here that substitution
is happening and we do have complete tests of the substitution logic in its own
unit tests.

+}
+
+}  // namespace policy