[LayoutNG] Logicalize NGPaintBorderEdge

third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
index ef247607828dfc3918caf11a4037600ac72ab417..16e810889eedcb28a425ec3895fe88e119b0469a 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
@@ -16,6 +16,7 @@ NGPhysicalBoxFragment::NGPhysicalBoxFragment(
     Vector<NGPositionedFloat>& positioned_floats,
     const WTF::Optional<NGLogicalOffset>& bfc_offset,
     const NGMarginStrut& end_margin_strut,
+    NGBorderEdges::Physical border_edges,
     RefPtr<NGBreakToken> break_token)
     : NGPhysicalFragment(layout_object,
                          size,
@@ -26,6 +27,7 @@ NGPhysicalBoxFragment::NGPhysicalBoxFragment(
       bfc_offset_(bfc_offset),
       end_margin_strut_(end_margin_strut) {
   children_.swap(children);
+  border_edge_ = border_edges;

[ikilpatrick, 2017/05/31 13:52:58]

this can't be part of the initializer list?

[kojii, 2017/05/31 15:09:36]

No, because |border_edges_| is in parent's class. I'm not sure how it ended up
in NGPhysicalFragment, not in NGPhysicalBoxFragment, I suppose it's only needed
for Box, but put in NGPhysicalFragment can save memory?

I can:
a. Move this to constructor argument if other subclasses might use it.
b. Move the field and functions down to Box (and thus can use initializer list).
c. Fields can stay in NGPhysicalFragment to save memory, but move functions down
to Box.
d. Add TODO for now, we haven't determined yet if other fragments are going to
use this or not.

I guessed d., too many unknowns in paint yet and we expect cleanup later, but if
you have any directions in mind, I'd be happy to learn.

[ikilpatrick, 2017/05/31 16:44:37]

Oh this is fine then, sorry I didn't realize it was in another class. 

still lgtm.

 }
 
 }  // namespace blink