MD Settings: Show all content settings in Site Details.

chrome/test/data/webui/settings/site_details_permission_tests.js

Index: chrome/test/data/webui/settings/site_details_permission_tests.js
diff --git a/chrome/test/data/webui/settings/site_details_permission_tests.js b/chrome/test/data/webui/settings/site_details_permission_tests.js
index 309f555e82994c1370abc5c8dd7e895b025ed55c..08d7289b1ae16ea4bf732ce9da4de04a8c508651 100644
--- a/chrome/test/data/webui/settings/site_details_permission_tests.js
+++ b/chrome/test/data/webui/settings/site_details_permission_tests.js
@@ -48,6 +48,10 @@ suite('SiteDetailsPermission', function() {
     settings.SiteSettingsPrefsBrowserProxyImpl.instance_ = browserProxy;
     PolymerTest.clearBody();
     testElement = document.createElement('site-details-permission');
+
+    // Set the camera icon on <site-details-permission> manually to avoid
+    // failures on undefined icons. In practice, this is done from the parent.

[calamity, 2017/06/01 03:46:56]

nit: ...icons during teardown in PolymerTest.testIronIcons.

[Patti Lor, 2017/06/01 04:52:01]

Done.

+    testElement.icon = 'settings:videocam';
     document.body.appendChild(testElement);
   });
 
@@ -77,19 +81,6 @@ suite('SiteDetailsPermission', function() {
         });
   };
 
-  test('empty state', function() {
-    browserProxy.setPrefs(prefsEmpty);
-    testElement.category = settings.ContentSettingsTypes.CAMERA;
-    testElement.site = {
-      origin: 'http://www.google.com',
-      embeddingOrigin: '',
-    };
-
-    return browserProxy.whenCalled('getExceptionList').then(function() {
-      assertTrue(testElement.$.details.hidden);
-    });
-  });
-
   test('camera category', function() {
     var origin = 'https://www.example.com';
     browserProxy.setPrefs(prefs);
@@ -155,25 +146,4 @@ suite('SiteDetailsPermission', function() {
               origin, settings.PermissionValues.BLOCK);
         });
   });
-
-  test('disappear on empty', function() {
-    var origin = 'https://www.example.com';
-    browserProxy.setPrefs(prefs);
-    testElement.category = settings.ContentSettingsTypes.CAMERA;
-    testElement.site = {
-      origin: origin,
-      embeddingOrigin: '',
-    };
-
-    return browserProxy.whenCalled('getExceptionList')
-        .then(function() {
-          assertFalse(testElement.$.details.hidden);
-
-          browserProxy.setPrefs(prefsEmpty);
-          return browserProxy.whenCalled('getExceptionList');
-        })
-        .then(function() {
-          assertTrue(testElement.$.details.hidden);
-        });
-  });
 });