MD Settings: Show all content settings in Site Details.

chrome/test/data/webui/settings/site_details_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-details. */
 suite('SiteDetails', function() {
   /**
    * A site list element created before each test.
    * @type {SiteDetails}
    */
@@ skipping 97 matching lines @@
 
   // Initialize a site-details before each test.
   setup(function() {
     browserProxy = new TestSiteSettingsPrefsBrowserProxy();
     settings.SiteSettingsPrefsBrowserProxyImpl.instance_ = browserProxy;
     PolymerTest.clearBody();
     testElement = document.createElement('site-details');
     document.body.appendChild(testElement);
   });
 
-  test('empty state', function() {
-    var category = settings.ContentSettingsTypes.NOTIFICATIONS;
-    var site = {
-      origin: 'http://www.google.com',
-      displayName: 'http://www.google.com',
-      embeddingOrigin: '',
-    };
-    browserProxy.setPrefs(prefsEmpty);
-    testElement.category = category;
-    testElement.site = site
-
-    // expect usage to not be rendered
-    assertFalse(!!testElement.$$('#usage'));
-
-    // TODO(finnur): Check for the Permission heading hiding when no
-    // permissions are showing.
-
-    var msg = 'No category should be showing, height';
-    assertEquals(0, testElement.$.camera.offsetHeight, msg);
-    assertEquals(0, testElement.$.cookies.offsetHeight, msg);
-    assertEquals(0, testElement.$.geolocation.offsetHeight, msg);
-    assertEquals(0, testElement.$.javascript.offsetHeight, msg);
-    assertEquals(0, testElement.$.mic.offsetHeight, msg);
-    assertEquals(0, testElement.$.notification.offsetHeight, msg);
-    assertEquals(0, testElement.$.popups.offsetHeight, msg);
-  });
-
-  test('all categories visible', function() {
+  test('all categories', function() {
     var category = settings.ContentSettingsTypes.NOTIFICATIONS;
     var site = {
       origin: 'https://foo-allow.com:443',
       displayName: 'https://foo-allow.com:443',
       embeddingOrigin: '',
     };
 
     browserProxy.setPrefs(prefs);
     testElement.category = category;
     testElement.site = site;
 
     var msg = 'All categories should be showing';
-    assertFalse(testElement.$.camera.hidden, msg);
-    assertFalse(testElement.$.cookies.hidden, msg);
-    assertFalse(testElement.$.geolocation.hidden, msg);
-    assertFalse(testElement.$.javascript.hidden, msg);
-    assertFalse(testElement.$.mic.hidden, msg);
-    assertFalse(testElement.$.notification.hidden, msg);
-    assertFalse(testElement.$.popups.hidden, msg);
+    assertTrue(!!testElement.$.automaticDownloads);
+    assertTrue(!!testElement.$.backgroundSync);
+    assertTrue(!!testElement.$.camera);
+    assertTrue(!!testElement.$.cookies);
+    assertTrue(!!testElement.$.geolocation);
+    assertTrue(!!testElement.$.javascript);
+    assertTrue(!!testElement.$.mic);
+    assertTrue(!!testElement.$.notifications);
+    assertTrue(!!testElement.$.plugins);
+    assertTrue(!!testElement.$.popups);
+    assertTrue(!!testElement.$.unsandboxedPlugins);

[calamity, 2017/06/01 03:46:56]

I don't this tests what you want it to. It just checks the the element exists,
which will always be true. I think it's fine to remove this whole test.

[Patti Lor, 2017/06/01 04:52:01]

Done! Thanks, I was kinda unsure if it was really that useful any more.

   });
 
   test('usage heading shows on storage available', function() {
     // Remove the current website-usage-private-api element.
     var parent = testElement.$.usageApi.parentNode;
     testElement.$.usageApi.remove();
 
     // Replace it with a mock version.
     Polymer({
       is: 'mock-website-usage-private-api',
@@ skipping 12 matching lines @@
       displayName: 'https://foo-allow.com:443',
       embeddingOrigin: '',
     };
 
     Polymer.dom.flush();
 
     // expect usage to be rendered
     assertTrue(!!testElement.$$('#usage'));
   });
 });