MD Settings: Show all content settings in Site Details.

chrome/test/data/webui/settings/site_details_permission_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-details. */
 suite('SiteDetailsPermission', function() {
   /**
    * A site list element created before each test.
    * @type {SiteDetailsPermission}
    */
@@ skipping 30 matching lines @@
       ]
     }
   };
 
   // Initialize a site-details-permission before each test.
   setup(function() {
     browserProxy = new TestSiteSettingsPrefsBrowserProxy();
     settings.SiteSettingsPrefsBrowserProxyImpl.instance_ = browserProxy;
     PolymerTest.clearBody();
     testElement = document.createElement('site-details-permission');
+
+    // Set the camera icon on <site-details-permission> manually to avoid
+    // failures on undefined icons. In practice, this is done from the parent.

[calamity, 2017/06/01 03:46:56]

nit: ...icons during teardown in PolymerTest.testIronIcons.

[Patti Lor, 2017/06/01 04:52:01]

Done.

+    testElement.icon = 'settings:videocam';
     document.body.appendChild(testElement);
   });
 
   // Tests that the given value is converted to the expected value, for a
   // given prefType.
   function isAllowed(origin, exceptionList) {
     for (var i = 0; i < exceptionList.length; ++i) {
       if (exceptionList[i].origin == origin)
         return exceptionList[i].setting == 'allow';
     }
     return false;
   };
 
   function validatePermissionFlipWorks(origin, expectedPermissionValue) {
     browserProxy.resetResolver('setCategoryPermissionForOrigin');
 
     // Simulate permission change initiated by the user.
     testElement.$.permission.value = expectedPermissionValue;
     testElement.$.permission.dispatchEvent(new CustomEvent('change'));
 
     return browserProxy.whenCalled('setCategoryPermissionForOrigin')
         .then(function(args) {
           assertEquals(origin, args[0]);
           assertEquals('', args[1]);
           assertEquals(testElement.category, args[2]);
           assertEquals(expectedPermissionValue, args[3]);
         });
   };
 
-  test('empty state', function() {
-    browserProxy.setPrefs(prefsEmpty);
-    testElement.category = settings.ContentSettingsTypes.CAMERA;
-    testElement.site = {
-      origin: 'http://www.google.com',
-      embeddingOrigin: '',
-    };
-
-    return browserProxy.whenCalled('getExceptionList').then(function() {
-      assertTrue(testElement.$.details.hidden);
-    });
-  });
-
   test('camera category', function() {
     var origin = 'https://www.example.com';
     browserProxy.setPrefs(prefs);
     testElement.category = settings.ContentSettingsTypes.CAMERA;
     testElement.label = 'Camera';
     testElement.site = {
       origin: origin,
       embeddingOrigin: '',
     };
 
@@ skipping 45 matching lines @@
         .then(function() {
           // Flip the permission and validate that prefs stay in sync.
           return validatePermissionFlipWorks(
               origin, settings.PermissionValues.ALLOW);
         })
         .then(function() {
           return validatePermissionFlipWorks(
               origin, settings.PermissionValues.BLOCK);
         });
   });
-
-  test('disappear on empty', function() {
-    var origin = 'https://www.example.com';
-    browserProxy.setPrefs(prefs);
-    testElement.category = settings.ContentSettingsTypes.CAMERA;
-    testElement.site = {
-      origin: origin,
-      embeddingOrigin: '',
-    };
-
-    return browserProxy.whenCalled('getExceptionList')
-        .then(function() {
-          assertFalse(testElement.$.details.hidden);
-
-          browserProxy.setPrefs(prefsEmpty);
-          return browserProxy.whenCalled('getExceptionList');
-        })
-        .then(function() {
-          assertTrue(testElement.$.details.hidden);
-        });
-  });
 });