Add compile_from_dill test

Add compile_from_dill test

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/38cdfde3412ae69a63264d0ba7efc4f6e3182cf8

[Johnni Winther, 2017-05-30 12:57:08]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-30 22:34:43]

lgtm!

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart (right):

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart:1908: //
TODO(johnniwinther): Add `isMirrorsUsed` to [BackendData] instead
+1 - to take this a step further, should we have a notion of a compiler
"configuration" that we serialize here?

Besides csp and mirrors, I'd like to see:
 - the emitter (full/startup)
 - trust flags (trust-types/trust-primitives)
 - optimization levels (disable-inference, no-inlining, and -once we add it-
something like "minimal optimizations")
 - ast vs kernel :)

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:1123: // TODO(johnniwinther): Support [cls] as a
[ClassEntity].
nit: move the TODO to the `if` below

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:1132: if (cls is! ClassElement) {
should we just do this upfront instead?

https://codereview.chromium.org/2912083002/diff/1/tests/compiler/dart2js/outp...
File tests/compiler/dart2js/output_collector.dart (right):

https://codereview.chromium.org/2912083002/diff/1/tests/compiler/dart2js/outp...
tests/compiler/dart2js/output_collector.dart:25: String toString() {
I didn't see where this was used? only for debugging?

[Johnni Winther, 2017-05-31 09:07:38]

Description was changed from

==========
Add compile_from_dill test
==========

to

==========
Add compile_from_dill test

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/38cdfde3412ae69a63264d0ba7efc4f6e3182cf8
==========

[Johnni Winther, 2017-05-31 09:07:40]

Committed patchset #2 (id:20001) manually as
38cdfde3412ae69a63264d0ba7efc4f6e3182cf8 (presubmit successful).

[Johnni Winther, 2017-05-31 09:08:40]

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart (right):

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart:1908: //
TODO(johnniwinther): Add `isMirrorsUsed` to [BackendData] instead
On 2017/05/30 22:34:42, Siggi Cherem (dart-lang) wrote:
> +1 - to take this a step further, should we have a notion of a compiler
> "configuration" that we serialize here?
> 
> Besides csp and mirrors, I'd like to see:
>  - the emitter (full/startup)
>  - trust flags (trust-types/trust-primitives)
>  - optimization levels (disable-inference, no-inlining, and -once we add it-
> something like "minimal optimizations")
>  - ast vs kernel :)
>  

Acknowledged.

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:1123: // TODO(johnniwinther): Support [cls] as a
[ClassEntity].
On 2017/05/30 22:34:42, Siggi Cherem (dart-lang) wrote:
> nit: move the TODO to the `if` below

Done.

https://codereview.chromium.org/2912083002/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:1132: if (cls is! ClassElement) {
On 2017/05/30 22:34:43, Siggi Cherem (dart-lang) wrote:
> should we just do this upfront instead?

Done.

https://codereview.chromium.org/2912083002/diff/1/tests/compiler/dart2js/outp...
File tests/compiler/dart2js/output_collector.dart (right):

https://codereview.chromium.org/2912083002/diff/1/tests/compiler/dart2js/outp...
tests/compiler/dart2js/output_collector.dart:25: String toString() {
On 2017/05/30 22:34:43, Siggi Cherem (dart-lang) wrote:
> I didn't see where this was used? only for debugging?

For debugging