Source/core/page/NetworkStateNotifier.h - Issue 291203002: Adds NetInfo v3 Web API to Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/NetworkStateNotifier.h

Issue 291203002: Adds NetInfo v3 Web API to Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@netinfo1

Patch Set: DEFINE_STATIC_LOCAL isn't thread safe Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/NetworkStateNotifier.h

diff --git a/Source/core/page/NetworkStateNotifier.h b/Source/core/page/NetworkStateNotifier.h

index e60b93b64ff7636ee1e9cef386ce53ca59750f31..138aaf52dd24d29c9ce69ad0fa9bd7be9317b10b 100644

--- a/Source/core/page/NetworkStateNotifier.h

+++ b/Source/core/page/NetworkStateNotifier.h

@@ -69,8 +69,10 @@ public:

void setWebConnectionType(blink::WebConnectionType);

- // Must be called on the context's thread. An added observer must be

- // removed before its ExecutionContext is deleted.

+ // Must be called on the context's thread. An added observer must be removed

+ // before its ExecutionContext is deleted. It's possible for an observer to

+ // be called twice for the same event if it is first removed and then added

+ // during notification.

void addObserver(NetworkStateObserver*, ExecutionContext*);

void removeObserver(NetworkStateObserver*, ExecutionContext*);