Source/modules/netinfo/NetworkInfoConnection.idl - Issue 291203002: Adds NetInfo v3 Web API to Blink.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/netinfo/NetworkInfoConnection.idl

Issue 291203002: Adds NetInfo v3 Web API to Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@netinfo1

Patch Set: Simplified layout tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 enum NetworkInfoConnectionType {
	adamk 2014/05/27 21:44:27 This name doesn't match the spec (which just says This name doesn't match the spec (which just says "ConnectionType"). But maybe that's of no consequence? jkarlin 2014/05/28 13:31:30 Done. Show quoted text On 2014/05/27 21:44:27, adamk wrote: > This name doesn't match the spec (which just says "ConnectionType"). But maybe > that's of no consequence? Done.
	6 "cellular",

	7 "bluetooth",

	8 "ethernet",

	9 "wifi",

	10 "other",

	11 "none"

	12 };

	13

	14 [

	15 RuntimeEnabled=NetworkInfo,

	16 Exposed=Window&Worker,
	adamk 2014/05/27 21:44:27 I don't see any worker support or tests in this ch I don't see any worker support or tests in this change. Should this just be Window for now? jkarlin 2014/05/28 13:31:30 Done. Show quoted text On 2014/05/27 21:44:27, adamk wrote: > I don't see any worker support or tests in this change. Should this just be > Window for now? Done.
	17 WillBeGarbageCollected,

	18 ActiveDOMObject

	19 ]

	20 interface NetworkInfoConnection : EventTarget {
	adamk 2014/05/27 21:44:27 Nit: I think this line should be merged into the p Nit: I think this line should be merged into the previous line, i.e.: ] interface NetworkInfoConnection ... adamk 2014/05/27 21:44:27 The spec calls this "NetworkInformation", why the The spec calls this "NetworkInformation", why the difference here? That's a web-exposed difference for sure. jkarlin 2014/05/28 13:31:30 Done. Show quoted text On 2014/05/27 21:44:27, adamk wrote: > Nit: I think this line should be merged into the previous line, i.e.: > > ] interface NetworkInfoConnection ... Done. jkarlin 2014/05/28 13:31:30 Done. Show quoted text On 2014/05/27 21:44:27, adamk wrote: > The spec calls this "NetworkInformation", why the difference here? That's a > web-exposed difference for sure. Done.
	21 readonly attribute NetworkInfoConnectionType type;

	22 attribute EventHandler ontypechange;

	23 };

	24

OLD	NEW