Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: chrome/browser/extensions/warning_badge_service.cc

Issue 2912003002: Replace deprecated base::NonThreadSafe in chrome/browser/extensions in favor of SequenceChecker. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/warning_badge_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/warning_badge_service.cc
diff --git a/chrome/browser/extensions/warning_badge_service.cc b/chrome/browser/extensions/warning_badge_service.cc
index 130443e32456ad3a93606d6bb8ff61b784474a3c..749aee946df3dff3e346ee8acd9c0b8b626551d8 100644
--- a/chrome/browser/extensions/warning_badge_service.cc
+++ b/chrome/browser/extensions/warning_badge_service.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/ui/global_error/global_error_service.h"
#include "chrome/browser/ui/global_error/global_error_service_factory.h"
#include "chrome/grit/generated_resources.h"
+#include "content/public/browser/browser_thread.h"
#include "ui/base/l10n/l10n_util.h"
namespace extensions {
@@ -101,11 +102,12 @@ int ErrorBadge::GetMenuItemCommandID() {
WarningBadgeService::WarningBadgeService(Profile* profile)
: profile_(profile), warning_service_observer_(this) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
warning_service_observer_.Add(WarningService::Get(profile_));
}
WarningBadgeService::~WarningBadgeService() {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
}
// static
@@ -115,7 +117,7 @@ WarningBadgeService* WarningBadgeService::Get(
}
void WarningBadgeService::SuppressCurrentWarnings() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
size_t old_size = suppressed_warnings_.size();
const WarningSet& warnings = GetCurrentWarnings();
@@ -131,7 +133,7 @@ const WarningSet& WarningBadgeService::GetCurrentWarnings() const {
void WarningBadgeService::ExtensionWarningsChanged(
const ExtensionIdSet& affected_extensions) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
UpdateBadgeStatus();
}
« no previous file with comments | « chrome/browser/extensions/warning_badge_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698