Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: chrome/browser/extensions/warning_badge_service.cc

Issue 2912003002: Replace deprecated base::NonThreadSafe in chrome/browser/extensions in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/warning_badge_service.cc
diff --git a/chrome/browser/extensions/warning_badge_service.cc b/chrome/browser/extensions/warning_badge_service.cc
index 130443e32456ad3a93606d6bb8ff61b784474a3c..3b3024516e639250041d9bf344feb99fe81a639e 100644
--- a/chrome/browser/extensions/warning_badge_service.cc
+++ b/chrome/browser/extensions/warning_badge_service.cc
@@ -101,11 +101,12 @@ int ErrorBadge::GetMenuItemCommandID() {
WarningBadgeService::WarningBadgeService(Profile* profile)
: profile_(profile), warning_service_observer_(this) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
warning_service_observer_.Add(WarningService::Get(profile_));
}
WarningBadgeService::~WarningBadgeService() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
}
// static
@@ -115,7 +116,7 @@ WarningBadgeService* WarningBadgeService::Get(
}
void WarningBadgeService::SuppressCurrentWarnings() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
size_t old_size = suppressed_warnings_.size();
const WarningSet& warnings = GetCurrentWarnings();
@@ -131,7 +132,7 @@ const WarningSet& WarningBadgeService::GetCurrentWarnings() const {
void WarningBadgeService::ExtensionWarningsChanged(
const ExtensionIdSet& affected_extensions) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
UpdateBadgeStatus();
}

Powered by Google App Engine
This is Rietveld 408576698