Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: content/browser/appcache/appcache_job.h

Issue 2911983004: Replace deprecated base::NonThreadSafe in content/browser/appcache in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/appcache/appcache_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_job.h
diff --git a/content/browser/appcache/appcache_job.h b/content/browser/appcache/appcache_job.h
index bc7a14b83b01c72b0427612472ec0d8208a74021..e43bb121c52b05caffe48c863422d561e72a2ce4 100644
--- a/content/browser/appcache/appcache_job.h
+++ b/content/browser/appcache/appcache_job.h
@@ -9,8 +9,8 @@
#include "base/logging.h"
#include "base/memory/weak_ptr.h"
+#include "base/sequence_checker.h"
#include "base/strings/string16.h"
-#include "base/threading/non_thread_safe.h"
#include "content/common/content_export.h"
#include "url/gurl.h"
@@ -33,9 +33,7 @@ class URLRequestJob;
// Subclasses implement this interface to wrap custom job objects like
// URLRequestJob, URLLoaderJob, etc to ensure that these dependencies stay out
// of the AppCache code.
-class CONTENT_EXPORT AppCacheJob
- : NON_EXPORTED_BASE(public base::NonThreadSafe),
- public base::SupportsWeakPtr<AppCacheJob> {
+class CONTENT_EXPORT AppCacheJob : public base::SupportsWeakPtr<AppCacheJob> {
public:
// Callback that will be invoked before the request is restarted. The caller
// can use this opportunity to grab state from the job to determine how it
@@ -111,6 +109,8 @@ class CONTENT_EXPORT AppCacheJob
protected:
AppCacheJob();
+ SEQUENCE_CHECKER(sequence_checker_);
+
base::WeakPtrFactory<AppCacheJob> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(AppCacheJob);
« no previous file with comments | « no previous file | content/browser/appcache/appcache_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698