Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 291193012: Renames IViewManagerClient::OnConnectionEstablished (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Renames IViewManagerClient::OnConnectionEstablished InterfaceImpl has a function of the same name. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272646

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +3 lines, -3 lines 1 comment Download
M mojo/services/view_manager/view_manager_connection.h View 2 chunks +3 lines, -2 lines 1 comment Download
M mojo/services/view_manager/view_manager_connection.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
https://codereview.chromium.org/291193012/diff/1/mojo/services/view_manager/view_manager_connection.h File mojo/services/view_manager/view_manager_connection.h (right): https://codereview.chromium.org/291193012/diff/1/mojo/services/view_manager/view_manager_connection.h#newcode180 mojo/services/view_manager/view_manager_connection.h:180: virtual void OnConnectionEstablished() MOJO_OVERRIDE; I'm not changing anything here, ...
6 years, 7 months ago (2014-05-23 19:11:55 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/291193012/diff/1/mojo/services/public/interfaces/view_manager/view_manager.mojom File mojo/services/public/interfaces/view_manager/view_manager.mojom (right): https://codereview.chromium.org/291193012/diff/1/mojo/services/public/interfaces/view_manager/view_manager.mojom#newcode104 mojo/services/public/interfaces/view_manager/view_manager.mojom:104: OnViewManagerConnectionEstablished(uint16 connection_id, I suspect this will evolve into ...
6 years, 7 months ago (2014-05-23 20:21:46 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-23 20:46:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/291193012/1
6 years, 7 months ago (2014-05-23 20:47:07 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 00:04:45 UTC) #5
Message was sent while issue was closed. 
Change committed as 272646

Powered by Google App Engine
This is Rietveld 408576698