Issue 291193011: Check for cached transition to ExternalArray elements kind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291193011: Check for cached transition to ExternalArray elements kind. (Closed)

Created:
6 years, 7 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 7 months ago

Reviewers:
Igor Sheludko, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Check for cached transition to ExternalArray elements kind. R=ishell@chromium.org, verwaest@chromium.org BUG=v8:3337 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=21466

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	src/objects.cc	View		1 chunk	+8 lines, -1 line	1 comment	Download
	M	test/cctest/test-api.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/291193011/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/291193011/diff/1/src/objects.cc#newcode3383 src/objects.cc:3383: // allows to change elements ...

6 years, 7 months ago (2014-05-23 12:24:14 UTC) #2

Dmitry Lomov (no reviews)

6 years, 7 months ago (2014-05-23 14:01:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21466 (presubmit successful).

Expand Messages | Collapse Messages